Fix docker issues, TTL cleanup #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with local testing and Docker where redis containers would fail to come up. Previously, each pytest xdist worker would attempt to connect to its own redis instance. If the instance failed to come up in time, the configuration defaulted to localhost: 6379. As long as a redis instance is running locally, the problem would have been masked, but this causes the tests to fail when a local redis instance is unavailable.
We attempt to resolve the issue by waiting longer for individual redis containers to become available. In the previous configuration, it was also possible for multiple xdist workers to start redis instances mapped to the same port (causing conflicts). We resolve this by giving each xdist worker a random, non-conflicting host port for their redis instance.