fix(checkpoint-redis): resolve key generation inconsistency in shallo… #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w savers Fix incomplete cleanup of blobs and writes in ShallowRedisSaver and AsyncShallowRedisSaver due to inconsistent key generation between base class and shallow cleanup patterns. The base class uses storage-safe transformations (to_storage_safe_id/to_storage_safe_str) which convert empty checkpoint_ns to "__empty__", while shallow cleanup patterns used raw empty strings, causing cleanup operations to miss actual keys. Changes: - Update _make_shallow_redis_checkpoint_blob_key_pattern to use to_storage_safe_id/to_storage_safe_str - Update _make_shallow_redis_checkpoint_writes_key_pattern to use same transformations - Apply fixes to both sync (shallow.py) and async (ashallow.py) implementations - Add comprehensive tests to verify cleanup behavior and key generation consistency Fixes prevent memory leaks where old blob versions and writes accumulated instead of being properly cleaned up during checkpoint operations.
bsbodden
deleted the
bsb/fix-cleanup-blobs-and-writes-for-shallow-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…w savers
Fix incomplete cleanup of blobs and writes in ShallowRedisSaver and AsyncShallowRedisSaver
due to inconsistent key generation between base class and shallow cleanup patterns.
The base class uses storage-safe transformations (to_storage_safe_id/to_storage_safe_str)
which convert empty checkpoint_ns to "empty", while shallow cleanup patterns used
raw empty strings, causing cleanup operations to miss actual keys.
Changes:
Fixes prevent memory leaks where old blob versions and writes accumulated instead
of being properly cleaned up during checkpoint operations.