Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FieldName signature to VectorField #104

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Conversation

shacharPash
Copy link
Contributor

Fixes #102

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.02 ⚠️

Comparison is base (1981625) 93.29% compared to head (a1a71da) 93.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   93.29%   93.27%   -0.02%     
==========================================
  Files          77       77              
  Lines        4576     4582       +6     
  Branches      423      424       +1     
==========================================
+ Hits         4269     4274       +5     
- Misses        185      186       +1     
  Partials      122      122              
Impacted Files Coverage Δ
src/NRedisStack/Search/Query.cs 98.40% <66.66%> (+<0.01%) ⬆️
src/NRedisStack/Search/Schema.cs 95.65% <100.00%> (-0.44%) ⬇️
src/NRedisStack/Search/SearchResult.cs 92.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash added bug Something isn't working feature and removed feature labels Apr 3, 2023
@shacharPash shacharPash marked this pull request as ready for review April 3, 2023 11:28
@shacharPash shacharPash requested review from chayim and a team April 3, 2023 11:28
@shacharPash shacharPash added feature and removed feature bug Something isn't working labels Apr 4, 2023
@shacharPash shacharPash requested review from a team and vladvildanov April 4, 2023 15:18
@shacharPash shacharPash merged commit 26036f2 into master Apr 13, 2023
@shacharPash shacharPash deleted the Issue102/VectorField branch April 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema VectorField isn't congruent with the other Schema Types
3 participants