Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify test host and port #117

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Ability to specify test host and port #117

merged 2 commits into from
Apr 25, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Apr 24, 2023

pattern:

dotnet test --environment="REDIS=<redisServer:port>"

e.g:

dotnet test --environment="REDIS=172.17.0.1:6379"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shacharPash shacharPash requested review from chayim, slorello89 and a team April 24, 2023 12:44
@chayim chayim changed the title Add an Ability to Test on a differeent host than localhost Ability to specify test host and port Apr 25, 2023
@chayim chayim self-requested a review April 25, 2023 07:00
@chayim
Copy link
Contributor

chayim commented Apr 25, 2023

@shacharPash Can we change to allow for an environment variable called REDIS_URL that accepts a redis-style url, either redis://ip.address:6379 or ip.address:6379

eg: REDIS_URL=1.2.3.4:6379 or REDIS_URL=redis://1.2.3.4:6379

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ccae59f) 93.27% compared to head (e5900a7) 93.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          77       77           
  Lines        4582     4582           
  Branches      424      424           
=======================================
  Hits         4274     4274           
  Misses        186      186           
  Partials      122      122           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash merged commit a39b818 into master Apr 25, 2023
@shacharPash shacharPash deleted the ControlTestHost branch April 25, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants