Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Triggers and Functions #145

Merged
merged 20 commits into from
Jul 2, 2023
Merged

Support Triggers and Functions #145

merged 20 commits into from
Jul 2, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented May 29, 2023

Closes #140
Closes #141
Closes #142
Closes #143
Closes #144

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Patch coverage: 98.85% and project coverage change: +0.09 🎉

Comparison is base (dfb621d) 93.48% compared to head (704aa6d) 93.58%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   93.48%   93.58%   +0.09%     
==========================================
  Files          78       81       +3     
  Lines        4775     4862      +87     
  Branches      450      460      +10     
==========================================
+ Hits         4464     4550      +86     
  Misses        185      185              
- Partials      126      127       +1     
Impacted Files Coverage Δ
src/NRedisStack/Gears/GearsCommandBuilder.cs 98.14% <98.14%> (ø)
src/NRedisStack/Gears/GearsCommands.cs 100.00% <100.00%> (ø)
src/NRedisStack/Gears/GearsCommandsAsync.cs 100.00% <100.00%> (ø)
src/NRedisStack/ResponseParser.cs 95.53% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash changed the title Support (RG) TFUNCTION LOAD command Support RedisGears Commands May 30, 2023
@shacharPash shacharPash marked this pull request as ready for review June 4, 2023 11:45
@shacharPash shacharPash requested review from slorello89 and chayim June 4, 2023 11:45
@chayim
Copy link
Contributor

chayim commented Jun 4, 2023

@uglide tagged you for titling. I'll review the code tomorrow

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, small changes. Will update you with what I learn about the docker image so that we can merge this in.

@shacharPash shacharPash requested review from chayim and uglide June 7, 2023 12:37
@shacharPash shacharPash requested review from chayim and removed request for chayim June 27, 2023 13:04
@chayim chayim changed the title Support RedisGears Commands Support Triggers and Functions Jun 28, 2023
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts?

@shacharPash shacharPash requested a review from chayim June 29, 2023 12:46
@shacharPash shacharPash merged commit 0b6abaf into master Jul 2, 2023
@shacharPash shacharPash deleted the SupportRG/Load branch July 2, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RG.FCALLASYNC RG.FCALL RG.FUNCTION LIST RG.FUNCTION DEL RG.FUNCTION LOAD
3 participants