-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Query input in Explain & ExplainCli #149
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 93.58% 93.67% +0.09%
==========================================
Files 78 78
Lines 4769 4777 +8
Branches 448 450 +2
==========================================
+ Hits 4463 4475 +12
Misses 177 177
+ Partials 129 125 -4
☔ View full report in Codecov by Sentry. |
Currently, Explain and ExplainCli commands accept the Query class as input. Which made it possible to insert FT.SEARCH arguments as input to those commands.
In this PR I fixed it and now the commands receive a query of type string and not of type Query.