Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc 2646 streams tutorial code examples in C# #272

Merged
merged 16 commits into from
Apr 15, 2024

Conversation

andy-stark-redis
Copy link
Collaborator

@andy-stark-redis andy-stark-redis commented Apr 11, 2024

My first PR at Redis :-)

The code seems to display OK in the doc page but no doubt my coding style isn't quite right yet :-)

@andy-stark-redis andy-stark-redis added the documentation Improvements or additions to documentation label Apr 11, 2024
@andy-stark-redis andy-stark-redis self-assigned this Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (5d2998a) to head (2e0d4f4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          88       88           
  Lines        5425     5425           
  Branches      496      496           
=======================================
  Hits         5119     5119           
  Misses        180      180           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs build correctly. So, apart from check issues, this looks good to me. And congratulations on your first PR! \0/

andy-stark-redis and others added 10 commits April 12, 2024 10:17
@shacharPash
Copy link
Contributor

Closes #221

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@shacharPash
Copy link
Contributor

shacharPash commented Apr 14, 2024

@andy-stark-redis , Why the title is in 'c'? you meant C#?

@andy-stark-redis andy-stark-redis changed the title Doc 2646 streams tutorial code examples in c Doc 2646 streams tutorial code examples in C# Apr 15, 2024
@andy-stark-redis
Copy link
Collaborator Author

@andy-stark-redis , Why the title is in 'c'? you meant C#?

Yes, it was auto-generated by JIRA and I forgot to edit it! I've changed it now :-)

@andy-stark-redis andy-stark-redis merged commit 26ff438 into master Apr 15, 2024
20 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-2646-streams-tutorial-code-examples-in-c branch April 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants