-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc 2646 streams tutorial code examples in C# #272
Doc 2646 streams tutorial code examples in C# #272
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 88 88
Lines 5425 5425
Branches 496 496
=======================================
Hits 5119 5119
Misses 180 180
Partials 126 126 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs build correctly. So, apart from check issues, this looks good to me. And congratulations on your first PR! \0/
Closes #221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@andy-stark-redis , Why the title is in 'c'? you meant C#? |
Yes, it was auto-generated by JIRA and I forgot to edit it! I've changed it now :-) |
My first PR at Redis :-)
The code seems to display OK in the doc page but no doubt my coding style isn't quite right yet :-)