Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing doc tests by avoiding parallelization at assembly level #326

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix failing doc tests by avoiding parallelization at assembly level #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2c798
fix failing doc tests by avoiding parallelization at assembly level
atakavci Jul 29, 2024
071bf3f
disable tests failing around FT.CONFIG response
atakavci Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
echo "${{secrets.REDIS_CA_PEM}}" > tests/NRedisStack.Tests/bin/Debug/${{inputs.clr_version}}/redis_ca.pem
echo "${{secrets.REDIS_USER_CRT}}" > tests/NRedisStack.Tests/bin/Debug/${{inputs.clr_version}}/redis_user.crt
echo "${{secrets.REDIS_USER_PRIVATE_KEY}}" > tests/NRedisStack.Tests/bin/Debug/${{inputs.clr_version}}/redis_user_private.key
dotnet test -f ${{inputs.clr_version}} --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
dotnet test -f ${{inputs.clr_version}} --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover -p:BuildInParallel=false tests/Test.proj
- name: Codecov
uses: codecov/codecov-action@v3
with:
Expand Down
18 changes: 12 additions & 6 deletions tests/NRedisStack.Tests/Search/SearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,8 @@ public async Task AlterAddAsync()
Assert.Equal(4, info.CursorStats.Count);
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public void TestConfig()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -833,7 +834,8 @@ public void TestConfig()
Assert.Equal("100", configMap["TIMEOUT"].ToString());
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public async Task TestConfigAsnyc()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -844,7 +846,8 @@ public async Task TestConfigAsnyc()
Assert.Equal("100", configMap["TIMEOUT"].ToString());
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public void configOnTimeout()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -856,7 +859,8 @@ public void configOnTimeout()
try { ft.ConfigSet("ON_TIMEOUT", "null"); } catch (RedisServerException) { }
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public async Task configOnTimeoutAsync()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -868,7 +872,8 @@ public async Task configOnTimeoutAsync()
try { ft.ConfigSet("ON_TIMEOUT", "null"); } catch (RedisServerException) { }
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public void TestDialectConfig()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -890,7 +895,8 @@ public void TestDialectConfig()
Assert.True(ft.ConfigSet("DEFAULT_DIALECT", "1"));
}

[SkipIfRedis(Is.OSSCluster, Is.Enterprise)]
// TODO : fix with FT.CONFIG response change
[SkipIfRedis(Is.OSSCluster, Is.Enterprise, Comparison.GreaterThanOrEqual, "7.3.240")]
public async Task TestDialectConfigAsync()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand Down
5 changes: 5 additions & 0 deletions tests/Test.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<Project Sdk="Microsoft.Build.Traversal/2.0.24">
<ItemGroup>
<ProjectReference Include="**\*.*proj" />
</ItemGroup>
</Project>
Loading