-
Notifications
You must be signed in to change notification settings - Fork 42
Handle FT.PROFILE response (impacted with Coordinator) processing with "ProfilingInformation" #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
atakavci
merged 6 commits into
redis:master
from
atakavci:ali/ft.profile_ProfilingInformation
Jan 23, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d325e32
handle ft.profile response processing with "ProfilingInformation"
atakavci d62de2d
fix formatting
atakavci ad64d69
Merge branch 'master' into ali/ft.profile_ProfilingInformation
atakavci 40d2998
Merge branch 'master' into ali/ft.profile_ProfilingInformation
atakavci b39a87d
make old methods obsolete
atakavci ae9d862
Merge branch 'master' into ali/ft.profile_ProfilingInformation
atakavci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
using StackExchange.Redis; | ||
|
||
namespace NRedisStack.Search | ||
{ | ||
|
||
public class ProfilingInformation | ||
{ | ||
public RedisResult Info { get; private set; } | ||
public ProfilingInformation(RedisResult info) | ||
{ | ||
this.Info = info; | ||
} | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
using Xunit; | ||
|
||
namespace NRedisStack.Tests; | ||
|
||
public static class CustomAssertions | ||
{ | ||
// Generic method to assert that 'actual' is greater than 'expected' | ||
public static void GreaterThan<T>(T actual, T expected) where T : IComparable<T> | ||
{ | ||
Assert.True(actual.CompareTo(expected) > 0, | ||
$"Failure: Expected value to be greater than {expected}, but found {actual}."); | ||
} | ||
|
||
// Generic method to assert that 'actual' is less than 'expected' | ||
public static void LessThan<T>(T actual, T expected) where T : IComparable<T> | ||
{ | ||
Assert.True(actual.CompareTo(expected) < 0, | ||
$"Failure: Expected value to be less than {expected}, but found {actual}."); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be a lot of value-add here (in fact I think the old structure is cleaner), also - this is a major breaking change, so this really ought to be fleshed out much more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @slorello89, the intention is to avoid client API from throwing an exception due to response layout that Redis server provides across different versions. Considering, for a consumer app, server version would be updated first(most of the time), a fully mapped return type leaves consumer apps with no use of profile command when a breaking change on server side. Another compelling reason to not fully map is that command use cases are debugging purposes mostly.