Add SetFromFile and SetFromDirectory Commands for Json Files #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
chayim
reviewed
Nov 14, 2022
|
|
||
| //creating json string: | ||
| var obj = new Person { Name = "Shachar", Age = 23 }; | ||
| string json = JsonSerializer.Serialize(obj); |
There was a problem hiding this comment.
What happens in the case the content cannot be serialized as json?
shacharPash
changed the title
leibale
reviewed
Nov 15, 2022
leibale
reviewed
Nov 15, 2022
| /// <inheritdoc/> | ||
| public int SetFromDirectory(RedisValue path, string filesPath, When when = When.Always) | ||
| { | ||
| int inserted = 0; |
There was a problem hiding this comment.
This one looks too specific to me.. I don't think we should implement this function
BTW, I think that the users will want to warp all the SetFromFile calls with a MULTI
There was a problem hiding this comment.
I can agree on a multi. We have this in python - hence wanted to get it into other clients.
There was a problem hiding this comment.
I will implement support for Transactions and pipelines in the future and then I will change this command
chayim
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.