Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Coverage #54

Merged
merged 22 commits into from
Jan 4, 2023
Merged

Add More Coverage #54

merged 22 commits into from
Jan 4, 2023

Conversation

shacharPash
Copy link
Contributor

No description provided.

@shacharPash shacharPash marked this pull request as draft January 1, 2023 15:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Base: 68.38% // Head: 78.48% // Increases project coverage by +10.10% 🎉

Coverage data is based on head (032e4de) compared to base (d5e0d8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
+ Coverage   68.38%   78.48%   +10.10%     
===========================================
  Files          67       67               
  Lines        4659     4592       -67     
  Branches      446      440        -6     
===========================================
+ Hits         3186     3604      +418     
+ Misses       1278      828      -450     
+ Partials      195      160       -35     
Impacted Files Coverage Δ
src/NRedisStack/Graph/DataTypes/Edge.cs 86.11% <ø> (+16.66%) ⬆️
src/NRedisStack/Graph/DataTypes/GraphEntity.cs 46.15% <ø> (+2.56%) ⬆️
src/NRedisStack/Graph/DataTypes/Node.cs 89.18% <ø> (+16.21%) ⬆️
src/NRedisStack/Graph/DataTypes/Path.cs 57.89% <ø> (+1.48%) ⬆️
src/NRedisStack/Graph/GraphCommandBuilder.cs 94.44% <ø> (+23.98%) ⬆️
src/NRedisStack/Graph/GraphCommands.cs 81.48% <ø> (+12.46%) ⬆️
src/NRedisStack/Graph/Header.cs 46.42% <ø> (ø)
src/NRedisStack/Graph/Point.cs 56.66% <ø> (ø)
src/NRedisStack/Graph/Record.cs 32.43% <ø> (ø)
src/NRedisStack/Json/JsonCommands.cs 85.87% <ø> (+3.68%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from chayim January 3, 2023 15:49
@shacharPash shacharPash marked this pull request as ready for review January 3, 2023 15:49
.idea
tests/NRedisStack.Tests/lcov.net7.0.info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**/*.info

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shacharPash Are you still relying on the plugin with vscode? If so - we should at least update the README to tell users that if they'd like to do this - they can, and what plugin to install.

@shacharPash shacharPash merged commit 964aeae into master Jan 4, 2023
@shacharPash shacharPash deleted the MoreCoverage branch January 4, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants