Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing code coverage #56

Merged
merged 28 commits into from
Jan 12, 2023
Merged

Increasing code coverage #56

merged 28 commits into from
Jan 12, 2023

Conversation

shacharPash
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 78.52% // Head: 93.22% // Increases project coverage by +14.70% 🎉

Coverage data is based on head (f5eae2c) compared to base (0aa7b92).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #56       +/-   ##
===========================================
+ Coverage   78.52%   93.22%   +14.70%     
===========================================
  Files          67       66        -1     
  Lines        4601     4459      -142     
  Branches      440      420       -20     
===========================================
+ Hits         3613     4157      +544     
+ Misses        828      180      -648     
+ Partials      160      122       -38     
Impacted Files Coverage Δ
src/NRedisStack/Graph/DataTypes/Edge.cs 97.22% <ø> (+11.11%) ⬆️
src/NRedisStack/Graph/DataTypes/GraphEntity.cs 60.00% <0.00%> (+13.84%) ⬆️
src/NRedisStack/Graph/DataTypes/Node.cs 100.00% <ø> (+10.81%) ⬆️
src/NRedisStack/Graph/DataTypes/Path.cs 94.73% <ø> (+36.84%) ⬆️
src/NRedisStack/Graph/GraphCacheList.cs 100.00% <ø> (+11.42%) ⬆️
src/NRedisStack/Graph/GraphCommandBuilder.cs 94.44% <ø> (ø)
src/NRedisStack/Graph/GraphCommands.cs 89.43% <ø> (+7.94%) ⬆️
src/NRedisStack/Graph/Header.cs 85.71% <ø> (+39.28%) ⬆️
src/NRedisStack/Graph/Point.cs 83.33% <ø> (+26.66%) ⬆️
src/NRedisStack/Graph/Record.cs 94.59% <ø> (+62.16%) ⬆️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from chayim January 10, 2023 16:19
@chayim chayim changed the title Code Coverage Increasing code coverage Jan 11, 2023
@chayim
Copy link
Contributor

chayim commented Jan 11, 2023

@shacharPash in terms of increasing coveage, it looks good. In terms of the TODOs - I'd like @sazzad16 to weigh in.

@chayim chayim requested a review from a team January 11, 2023 13:13
@sazzad16
Copy link

ToString is dependent on the library (this) and the language (C#). Others can be removed. Just labeling breaking/breakingchange would be nicer.

@shacharPash
Copy link
Contributor Author

I deleted all the unnecessary TODOs,
What are you think about it now?
@chayim @sazzad16

@shacharPash shacharPash merged commit a6dadd6 into master Jan 12, 2023
@shacharPash shacharPash deleted the codecov2 branch January 12, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants