pipeline examples #75
Conversation
|
ready for review? |
* Adding a README to the nuget package * readme path * fixing readme path
| ``` | ||
|
|
||
| ## Search | ||
| Create the schema to index first and age as a numeric field |
There was a problem hiding this comment.
I didn't quite understand this sentence..
Did you mean to write something like this?
Create the schema to index name as text field, age as a numeric field and city as tag field.
There was a problem hiding this comment.
hey @Jeevananthan-23, thanks again :)
I added some comments.
There are still two things I wrote in the previous review.
- You should also give an example of creating a pipeline in this way:
var pipeline = new Pipeline(db);, Pipeline can getIDatabaseorIConnectionMultiplexerand I want to show this 2 option in the examples. - You need to add Assertions to the tests to make sure that what you wrote in the examples really gives the desired result.
|
@Jeevananthan-23 |
Codecov ReportBase: 93.32% // Head: 93.38% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## examples #75 +/- ##
============================================
+ Coverage 93.32% 93.38% +0.06%
============================================
Files 76 76
Lines 4555 4551 -4
Branches 422 422
============================================
- Hits 4251 4250 -1
+ Misses 181 179 -2
+ Partials 123 122 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@shacharPash this might be the long-running pipelining and it may occur often. |
Closes #61
Closes #62
Closes #65