Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support transaction #79

Merged

Conversation

Jeevananthan-23
Copy link
Contributor

Closes #64
Closes #78

@Jeevananthan-23 Jeevananthan-23 marked this pull request as ready for review February 4, 2023 19:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 93.38% // Head: 93.18% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (5be27b1) compared to base (1f00360).
Patch coverage: 44.44% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##           examples      #79      +/-   ##
============================================
- Coverage     93.38%   93.18%   -0.20%     
============================================
  Files            76       77       +1     
  Lines          4551     4566      +15     
  Branches        422      422              
============================================
+ Hits           4250     4255       +5     
- Misses          179      189      +10     
  Partials        122      122              
Impacted Files Coverage Δ
src/NRedisStack/Transactions.cs 41.17% <41.17%> (ø)
src/NRedisStack/Pipeline.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash changed the base branch from master to examples February 5, 2023 16:23
Assert.Equal("{\"Name\":\"Shachar\",\"Age\":23}", getResponse.Result.ToString());
}

/* [Fact]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this test in comment?

@shacharPash shacharPash merged commit 3a851a4 into redis:examples Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Transaction for Redis Stack Commands Create examples using this with transactions
3 participants