adjustments to run in .NET Framework, adding job to run tests for .NET Framework #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shacharPash
approved these changes
Mar 13, 2023
shacharPash
added a commit
that referenced
this pull request
Mar 15, 2023
* Target .NET Standard 2.0 * add condition * update to the latest version of System.Text.Json * adjustments to run in .NET Framework, adding job to run tests for .NET Framework * adjustments to run in .NET Framework, adding job to run tests for .NET Framework (#91) * syntax fix * trying to manually switch to linux containers * trying other format * fixing syntax * swapping flags * nixing windows job * try dropping framework restrictions * dropping 462 * trying to test on windows using WSL 2 * adding curl install * also installing gpg. . . * and lsb-release... * trying to log start * switching to ubuntu * change test name * delete distribution: Ubuntu-20.04 line * experiment * trying with direct tar download * ok let's actually add it this time * resetting as a jammy instance, adding a ls for debugging * removing mv * removing process spinoff * fixing syntax * libgomp1? * spin off again * trying a new tact for spinning off process * old school spin off? * renaming * versioning * newline * PS variable access * reverting * other means of seeding env vars? * add sleep to HSETandSearch test * add sleep to TestQueryCommandBuilderScore Test * conditional framework usage based on platform --------- Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Steve Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: slorello89 <steve.lorello@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to make a couple updates to get this to work with .NET Framework
System.Formatnot checking fornanThis might be something to take upstream to StackExchange.Redis - but I cannot think of a non-module command that returns ananso IMO it is, for the moment, something best managed by the derived library.MADDtests were adding the same timestamp over and over without setting a proper duplication policy - you might have a better sense as to why this would have worked at all, but I made the adjustment to set them right by sending a nonNO_DUPLICATEduplication policy.