Skip to content

Conversation

@nmammadli
Copy link
Contributor

No description provided.

/*
Verify after client list command columns are visible
*/
async verifyClientListColumnsAreVisible(): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to test it with loop and some dynamic selector.
e.g.
const columns = ['id', 'addr', 'name', 'user'];

for (const column of columns) {
let columnSelector = Selector([data-test-subj^=tableHeaderCell_${column}_]);
await t.expect(columnSelector.visible).ok(${column} column is not visible);
}

does it make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you will be able to test any number of columns described in "columns" array


test.before(async t => {
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneRedisearch, ossStandaloneRedisearch.databaseName);
// Add index and data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment

}).after(async t => {
await t.switchToMainWindow();
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
})('verify client list plugin shows table', async t => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this test name in checklist
you need to add it to Scenario column

await t.switchToIframe(workbenchPage.iframe);
// Verify that I can see the client List visualization available for all users.
await workBenchActions.verifyClientListColumnsAreVisible();
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can automate this scenarios as well:
"Verify that user can see the Client List visualization available for all users."
by checking the number of rows in table and comparing with the number of rows in text view
and also this scenario can be automated
Verify that user have the following error when there is no permission to run the CLIENT LIST: "NOPERM this user has no permissions to run the 'CLIENT LIST' command or its subcommand"

@nmammadli nmammadli requested a review from vlad-dargel February 2, 2023 13:08
@nmammadli nmammadli merged commit 46a587a into fe/feature/RI-4069_client-list Feb 3, 2023
@nmammadli nmammadli deleted the e2e/feature/RI-4069_client-list branch February 3, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants