Skip to content

merge tests fixes to release 2.20.0 #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Release/2.20.0
merged 2 commits into from
Feb 21, 2023
Merged

merge tests fixes to release 2.20.0 #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d1b6c
fix UI tests
egor-zalenski Feb 21, 2023
6a2a8a4
Merge pull request #1763 from RedisInsight/fe/fix_ui_tests
egor-zalenski Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions redisinsight/ui/src/components/analytics-tabs/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ export const analyticsViewTabs: AnalyticsTabs[] = [
{
id: AnalyticsViewTab.ClusterDetails,
label: 'Overview',
onboard: ONBOARDING_FEATURES.ANALYTICS_OVERVIEW
onboard: ONBOARDING_FEATURES?.ANALYTICS_OVERVIEW
},
{
id: AnalyticsViewTab.DatabaseAnalysis,
label: 'Database Analysis',
onboard: ONBOARDING_FEATURES.ANALYTICS_DATABASE_ANALYSIS
onboard: ONBOARDING_FEATURES?.ANALYTICS_DATABASE_ANALYSIS
},
{
id: AnalyticsViewTab.SlowLog,
label: 'Slow Log',
onboard: ONBOARDING_FEATURES.ANALYTICS_SLOW_LOG
onboard: ONBOARDING_FEATURES?.ANALYTICS_SLOW_LOG
},
]
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/config/Config.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jest.mock('uiSrc/services', () => ({
},
}))

const onboardingTotalSteps = Object.keys(ONBOARDING_FEATURES).length
const onboardingTotalSteps = Object.keys(ONBOARDING_FEATURES)?.length

describe('Config', () => {
it('should render', () => {
Expand Down
4 changes: 1 addition & 3 deletions redisinsight/ui/src/components/onboarding-features/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
import { ONBOARDING_FEATURES } from './OnboardingFeatures'

export { ONBOARDING_FEATURES }
export * from './OnboardingFeatures'
2 changes: 1 addition & 1 deletion redisinsight/ui/src/pages/databaseAnalysis/components/data-nav-tabs/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ export const databaseAnalysisTabs: DatabaseAnalysisTabs[] = [
id: DatabaseAnalysisViewTab.Recommendations,
name: (count?: number) => (count ? `Recommendations (${count})` : 'Recommendations'),
content: <Recommendations />,
onboard: ONBOARDING_FEATURES.ANALYTICS_RECOMMENDATIONS
onboard: ONBOARDING_FEATURES?.ANALYTICS_RECOMMENDATIONS
},
]