Skip to content

Conversation

GnaneshKunal
Copy link
Contributor

Fix: #3282

Use proxy path prefix in the theme keyname to respect multiple subpath instances running simultaneously.

@ArtemHoruzhenko
Copy link
Collaborator

In my opinion we must think about general solution. if I'm not mistaken RI might share local storage with another app when proxy path used. Let's design and implement solution

  1. where all our data in local storage will be placed under single property (e.g. ri). cons: pretty tricky to make it backward compatible
  2. OR save ALL local storage data under unique property based on ri proxy where by default data will be stored in the root. In this scenario we might ignore backward compatibility since very low number of users will be affected
    @GnaneshKunal @zalenskiSofteq @romansergeenkosofteq @kchepikava @ViktarStarastsenka wdyt?

@egor-zalenski
Copy link
Contributor

@ArtemHoruzhenko
reworked to store all storage data under uniq property here #4081

@ArtemHoruzhenko
Copy link
Collaborator

was done in this PR #4081

@ArtemHoruzhenko ArtemHoruzhenko deleted the bugfix/fe/theme-subpath-proxy branch November 21, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Redisinsight should change theme key of local storage

3 participants