Skip to content

[RI-6848] [RI-6842]: handle disabled INFO command for telemetry #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[RI-6848] [RI-6842]: handle disabled INFO command for telemetry #4382

wants to merge 2 commits into from

Conversation

KrumTy
Copy link
Collaborator

@KrumTy KrumTy commented Feb 19, 2025 •
edited
Loading

Description

  • Issue: revoking access to INFO via ACL causes areas of the app not to work
  • Solution: fallback to HELLO command where possible, otherwise refactor logic

Notes

ArtemHoruzhenko
ArtemHoruzhenko reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that covering hosting provider is not needed at all. We should not fail when there are no info or/and hello commands available and continue processing.

dantovska
dantovska reviewed Feb 19, 2025
View reviewed changes
redisinsight/api/src/modules/database/providers/database-overview.provider.ts

try {
infoData = await this.databaseInfoProvider.getRedisInfo(client);
} catch (e) {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not log the error here?

@KrumTy KrumTy changed the title RI-6848: handle disabled INFO command for telemetry [RI-6848] [RI-6842]: handle disabled INFO command for telemetry Feb 19, 2025
@KrumTy KrumTy closed this Feb 20, 2025
@KrumTy KrumTy deleted the feature/RI-6848/no-info-telemetry branch February 20, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtemHoruzhenko ArtemHoruzhenko ArtemHoruzhenko left review comments

@dantovska dantovska dantovska left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KrumTy @ArtemHoruzhenko @dantovska