-
Notifications
You must be signed in to change notification settings - Fork 406
[RI-7074] Replace EuiToolTip with RiTooltip #4659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KrumTy
merged 10 commits into
fe/feature/RI-7039-replace-eui
from
fe/feature/RI-7074/replace-EuiToolTip
Jul 4, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8e44be4
RI-7074: init RiTooltip
KrumTy 1d311c8
RI-7074: replace EuiTooltip with RITooltip
KrumTy f919c7b
update unit tests
KrumTy 0e54745
remove euiTooltip styles
KrumTy c9421e3
fix failing tests
KrumTy 010b688
cleanup TODOs
KrumTy 140ae87
resolve comments
KrumTy af1a3f9
Merge remote-tracking branch 'origin/fe/feature/RI-7039-replace-eui' …
KrumTy 4ab0b67
remove EuiTooltip
KrumTy da20e7a
expose TOOLTIP_DELAY_LONG constant
KrumTy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export { Text } from './Text' | ||
export { ColorText } from './ColorText' | ||
export { HealthText } from './HealthText' | ||
export { Title } from './Title' |
16 changes: 16 additions & 0 deletions
16
redisinsight/ui/src/components/base/tooltip/HoverContent.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import React from 'react' | ||
|
||
import { Col } from 'uiSrc/components/base/layout/flex' | ||
import { Title } from 'uiSrc/components/base/text' | ||
|
||
interface RiTooltipContentProps { | ||
title?: React.ReactNode | ||
content: React.ReactNode | ||
} | ||
|
||
export const HoverContent = ({ title, content }: RiTooltipContentProps) => ( | ||
<Col> | ||
{title && <Title size="S">{title}</Title>} | ||
{content} | ||
</Col> | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import React from 'react' | ||
|
||
import { TooltipProvider, Tooltip, TooltipProps } from '@redis-ui/components' | ||
import { HoverContent } from './HoverContent' | ||
|
||
export interface RiTooltipProps | ||
extends Omit<TooltipProps, 'placement' | 'openDelayDuration'> { | ||
title?: React.ReactNode | ||
position?: TooltipProps['placement'] | ||
delay?: TooltipProps['openDelayDuration'] | ||
} | ||
|
||
export const RiTooltip = ({ | ||
children, | ||
title, | ||
content, | ||
position, | ||
delay, | ||
...props | ||
}: RiTooltipProps) => ( | ||
<TooltipProvider> | ||
<Tooltip | ||
{...props} | ||
content={<HoverContent title={title} content={content} />} | ||
placement={position} | ||
openDelayDuration={delay} | ||
> | ||
<span>{children}</span> | ||
</Tooltip> | ||
</TooltipProvider> | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from './RITooltip' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,3 @@ | |
.abbr { | ||
vertical-align: text-top; | ||
} | ||
|
||
.anchorModuleTooltip { | ||
margin-right: 18px; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
redisinsight/ui/src/components/formated-date/styles.module.scss
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't wrap it in Title, unless it is a string. Title uses H1-2-3-... tags and whatever is passed to HoverContent might not be compatible or intended to be in a heading. Just something to consider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and it works fine even with nested jsx; Title's children are typed as ReactNode too