Skip to content

Feature/ri 7158 uninstalling ri desktop installed from deb file doesnt work #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
+46 −1
Merged

Feature/ri 7158 uninstalling ri desktop installed from deb file doesnt work #4667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac201ba
RI-7158 - Uninstalling RI desktop installed from deb file doesn't wor…
KIvanow Jul 8, 2025
18d40ff
RI-7158 - Uninstalling RI desktop installed from deb file doesn't wor…
KIvanow Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion electron-builder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@
}
},
"deb": {
"afterInstall": "scripts/deb-after-install.sh"
"afterInstall": "scripts/deb-after-install.sh",
"afterRemove": "scripts/deb-before-remove.sh"
},
"snap": {
"plugs": ["default", "password-manager-service"],
Expand Down
44 changes: 44 additions & 0 deletions scripts/deb-before-remove.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#!/bin/bash
set -e

OLD_INSTALL_PATH="/opt/Redis Insight"
NEW_INSTALL_PATH="/opt/redisinsight"
SYMLINK_PATH="/usr/bin/redisinsight"
DESKTOP_FILE="/usr/share/applications/redisinsight.desktop"

RUNNING_PIDS=$(pgrep -f "$NEW_INSTALL_PATH/redisinsight" || pgrep -f "$OLD_INSTALL_PATH/redisinsight" || true)

for PID in $RUNNING_PIDS; do
echo "Found running RedisInsight instance (PID: $PID), terminating..."
kill $PID 2>/dev/null || true
done

sleep 2

REMAINING_PIDS=$(pgrep -f "$NEW_INSTALL_PATH/redisinsight" || pgrep -f "$OLD_INSTALL_PATH/redisinsight" || true)
for PID in $REMAINING_PIDS; do
echo "Force killing remaining RedisInsight instance (PID: $PID)..."
kill -9 $PID 2>/dev/null || true
done

if [ -L "$SYMLINK_PATH" ]; then
echo "Removing symlink: $SYMLINK_PATH"
rm -f "$SYMLINK_PATH" || true
fi

if [ -d "$NEW_INSTALL_PATH" ]; then
echo "Removing directory: $NEW_INSTALL_PATH"
rm -rf "$NEW_INSTALL_PATH" || true
fi

if [ -d "$OLD_INSTALL_PATH" ]; then
echo "Removing old directory: $OLD_INSTALL_PATH" #if it still exists for any reason
rm -rf "$OLD_INSTALL_PATH" || true
fi

if command -v update-desktop-database >/dev/null 2>&1; then
echo "Updating desktop database..."
update-desktop-database 2>/dev/null || true
fi

echo "RedisInsight cleanup completed successfully"
Loading