-
Notifications
You must be signed in to change notification settings - Fork 406
[RI-7064]Replace EuiPopover with RiPopover #4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KrumTy
merged 8 commits into
fe/feature/RI-7039-replace-eui
from
fe/feature/RI-7064/replace-EuiPopup
Jul 10, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8575776
RI-7064: replace EuiPopup init
KrumTy 36fb825
replace EuiPopup with RiPopup
KrumTy 91ac886
fix some unit tests
KrumTy 4571e49
skip some unit tests
KrumTy 44ab607
remove EuiPopover reference
KrumTy fe356d5
fix tests
KrumTy b8b528b
Merge branch 'fe/feature/RI-7039-replace-eui' into fe/feature/RI-7064…
KrumTy 1e57c88
fix onboarding popover
KrumTy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import React from 'react' | ||
import { Popover } from '@redis-ui/components' | ||
|
||
import { RiPopoverProps } from './types' | ||
import { anchorPositionMap, panelPaddingSizeMap } from './config' | ||
|
||
export const RiPopover = ({ | ||
isOpen, | ||
closePopover, | ||
children, | ||
ownFocus, | ||
button, | ||
anchorPosition, | ||
panelPaddingSize, | ||
anchorClassName, | ||
panelClassName, | ||
maxWidth = '100%', | ||
...props | ||
}: RiPopoverProps) => ( | ||
<Popover | ||
{...props} | ||
open={isOpen} | ||
onClickOutside={closePopover} | ||
content={children} | ||
// Props passed to the children wrapper: | ||
className={panelClassName} | ||
maxWidth={maxWidth} | ||
style={{ | ||
padding: panelPaddingSize && panelPaddingSizeMap[panelPaddingSize], | ||
}} | ||
autoFocus={ownFocus} | ||
placement={anchorPosition && anchorPositionMap[anchorPosition]?.placement} | ||
align={anchorPosition && anchorPositionMap[anchorPosition]?.align} | ||
> | ||
<span className={anchorClassName}>{button}</span> | ||
</Popover> | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
export const anchorPositionMap = { | ||
upCenter: { | ||
placement: 'top', | ||
align: 'center', | ||
}, | ||
upLeft: { | ||
placement: 'top', | ||
align: 'start', | ||
}, | ||
upRight: { | ||
placement: 'top', | ||
align: 'end', | ||
}, | ||
downCenter: { | ||
placement: 'bottom', | ||
align: 'center', | ||
}, | ||
downLeft: { | ||
placement: 'bottom', | ||
align: 'start', | ||
}, | ||
downRight: { | ||
placement: 'bottom', | ||
align: 'end', | ||
}, | ||
leftCenter: { | ||
placement: 'left', | ||
align: 'center', | ||
}, | ||
leftUp: { | ||
placement: 'left', | ||
align: 'start', | ||
}, | ||
leftDown: { | ||
placement: 'left', | ||
align: 'end', | ||
}, | ||
rightCenter: { | ||
placement: 'right', | ||
align: 'center', | ||
}, | ||
rightUp: { | ||
placement: 'right', | ||
align: 'start', | ||
}, | ||
rightDown: { | ||
placement: 'right', | ||
align: 'end', | ||
}, | ||
} as const | ||
|
||
export const panelPaddingSizeMap = { | ||
l: 24, | ||
m: 18, | ||
s: 8, | ||
none: 0, | ||
} as const |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './RiPopover' | ||
export * from './types' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { type PopoverProps } from '@redis-ui/components' | ||
|
||
import { anchorPositionMap, panelPaddingSizeMap } from './config' | ||
|
||
type AnchorPosition = keyof typeof anchorPositionMap | ||
|
||
type PanelPaddingSize = keyof typeof panelPaddingSizeMap | ||
|
||
export type RiPopoverProps = Omit< | ||
PopoverProps, | ||
| 'open' | ||
| 'onClickOutside' | ||
| 'autoFocus' | ||
| 'content' | ||
| 'className' | ||
| 'placement' | ||
| 'align' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've changed the props a bit to preserve the previous structure and minimize the changes |
||
> & { | ||
isOpen?: PopoverProps['open'] | ||
closePopover?: PopoverProps['onClickOutside'] | ||
ownFocus?: PopoverProps['autoFocus'] | ||
button: PopoverProps['content'] | ||
anchorPosition?: AnchorPosition | ||
panelPaddingSize?: PanelPaddingSize | ||
anchorClassName?: string | ||
panelClassName?: string | ||
'data-testid'?: string | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why inline style and not styled component?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a composed component and wrapping it in styled component yields a lot of ts issues
Moreover, these props under the comment, are passed to the wrapper of the content by the Popover internally (ref)