Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/BannedIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/BulkActions.tsx

This file was deleted.

5 changes: 0 additions & 5 deletions redisinsight/ui/src/components/base/icons/Cloud.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/Copilot.tsx

This file was deleted.

8 changes: 0 additions & 8 deletions redisinsight/ui/src/components/base/icons/DislikeIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/ExtendIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/Group.tsx

This file was deleted.

6 changes: 0 additions & 6 deletions redisinsight/ui/src/components/base/icons/LikeIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/MinusInCircle.tsx

This file was deleted.

5 changes: 0 additions & 5 deletions redisinsight/ui/src/components/base/icons/Play.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/PlayFilled.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/PlusInCircle.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/ProfilerIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/RIResetIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/RIRocketIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/RIStopIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/RawMode.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/RedisLogo.tsx

This file was deleted.

This file was deleted.

14 changes: 2 additions & 12 deletions redisinsight/ui/src/components/base/icons/RiIcon.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
import React, { ImgHTMLAttributes, SVGProps } from 'react'
import cx from 'classnames'
import { IconProps } from './Icon'
import * as Icons from './index'
import * as Icons from './iconRegistry'

// Create a type that excludes the IconProps type
export type AllIconsType = Exclude<
keyof typeof Icons,
| 'IconProps'
| 'Icon'
| 'IconSizeType'
| 'IconColorType'
| 'ColorIconProps'
| 'MonochromeIconProps'
| 'IconType'
>
export type AllIconsType = keyof typeof Icons
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing refactoring, we can move this type in index.ts as well ...

Copy link
Collaborator Author

@KrumTy KrumTy Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to touch RiIcon and affect it's consumers; I think it's fine as it is

There are some imports to AllIconsType from icons/RiIcon and I'd rather keep the changes on base/icons folder level

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you prefer, but refactor is refactor.


export type IconComponentProps = Omit<IconProps, 'icon' | 'size'> &
Omit<SVGProps<SVGSVGElement>, 'color' | 'size'> & {
Expand Down
7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/ShrinkIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/SnoozeIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/StarsIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/SurveyIcon.tsx

This file was deleted.

8 changes: 0 additions & 8 deletions redisinsight/ui/src/components/base/icons/ThreeDotsIcon.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/Trigger.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions redisinsight/ui/src/components/base/icons/UserInCircle.tsx

This file was deleted.

Loading
Loading