-
Notifications
You must be signed in to change notification settings - Fork 407
[RI-7040] RiIcon refactor #4727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
18747be
b9ba0c9
15fc6e8
8658765
1c5254b
15c9eff
6304a55
5cc163d
2a1984d
d8ccc03
23dc231
1d8cd03
bcc89f8
a685ef1
24847a1
a9be67b
0097a7b
75a26a6
57517a9
fa086c9
2db1efa
74caa8f
cdd401f
04a7d04
5a807e6
983ab0e
f6ebc00
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're doing refactoring, we can move this type in index.ts as well ...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to touch RiIcon and affect it's consumers; I think it's fine as it is
There are some imports to AllIconsType from icons/RiIcon and I'd rather keep the changes on base/icons folder level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you prefer, but refactor is refactor.