RI-7613: fix last item remove popover #5047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ArtemHoruzhenko
commented
Oct 7, 2025
ArtemHoruzhenko
commented
| Before | After |
|---|---|
 |
 |
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from fe7e7f4 |
dantovska
previously approved these changes
Oct 7, 2025
dantovska
reviewed
Oct 7, 2025
| If you remove the single {fieldType}, the whole Key will be deleted. | ||
| </Text> | ||
| </div> | ||
| REMOVE_LAST_ELEMENT: (_fieldType: string) => ( |
There was a problem hiding this comment.
why do we need the field type if we are not using it?
valkirilov
previously approved these changes
Oct 8, 2025
KrumTy
previously approved these changes
Oct 8, 2025
ArtemHoruzhenko
dismissed stale reviews from KrumTy, valkirilov, and dantovska
via
fe7e7f4
dantovska
approved these changes
Oct 8, 2025
valkirilov
approved these changes
Oct 9, 2025
ArtemHoruzhenko
deleted the
fe/bugfix/RI-7613-fix-last-item-remove-popover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.