Expose router history #5118
Merged
Expose router history #5118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrumTy
requested review from
ArtemHoruzhenko,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
KrumTy
commented
Oct 29, 2025
|
|
||
| const riConfig = getConfig() | ||
|
|
||
| export const history = createBrowserHistory() |
Collaborator
Author
There was a problem hiding this comment.
this was not used and also it creates another instance - not the one from BrowserRouter, so it's also useless
Contributor
Code Coverage - Frontend unit tests
Test suite run success5229 tests passing in 681 suites. Report generated by 🧪jest coverage report action from 492a5dc |
pd-redis
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
We currently cannot navigate outside of react lifecycle/hooks. E.g. if we want to navigate from a method, we need to call
const history = useHistory()in a component and somehow pass the history as a prop.Use case - we have a lot of cells in a table and we don't want to call useHistory for each one of them if we can access the object directly.
Solution: