Skip to content

DEV: Enable more ESlint rules for UI #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DEV: Enable more ESlint rules for UI #5131

wants to merge 2 commits into from

Conversation

@pawelangelow
Copy link
Collaborator

@pawelangelow pawelangelow commented Oct 31, 2025

Again, go through commits:

  • enable prettier stuff - spaces, identation, etc...
  • remove unused variables - this way, dead code can be found easily, unused variables, etc...

@pawelangelow pawelangelow self-assigned this Oct 31, 2025
valkirilov
valkirilov previously approved these changes Oct 31, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025 •
edited
Loading

Code Coverage - Frontend unit tests

St.❔
 Category Percentage Covered / Total
🟢 Statements 82.25% 20144/24490
🟡 Branches 67.69% 8721/12884
🟡 Functions 76.39% 5359/7015
🟢 Lines 82.67% 19724/23860

Test suite run success

5229 tests passing in 681 suites.

Report generated by 🧪jest coverage report action from 73138ca

ArtemHoruzhenko
ArtemHoruzhenko requested changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it right now? Will it increase chances to have conflicts for our PRs?

Base automatically changed from feature/improve-eslint-stuff to main October 31, 2025 14:15
@pawelangelow pawelangelow dismissed valkirilov’s stale review October 31, 2025 14:15

The base branch was changed.

@pawelangelow pawelangelow force-pushed the fe/enable-more-eslint-rules-for-ui branch from 6f4498c to 73138ca Compare October 31, 2025 14:16
@pawelangelow
Copy link
Collaborator Author

pawelangelow commented Oct 31, 2025

Do we need it right now? Will it increase chances to have conflicts for our PRs?

Well, there's no suitable time for these PRs. Usually, if you pick your changes and then run yarn lint, you'll manage to resolve them pretty quickly.

@ArtemHoruzhenko
Copy link
Collaborator

ArtemHoruzhenko commented Nov 3, 2025

Do we need it right now? Will it increase chances to have conflicts for our PRs?

Well, there's no suitable time for these PRs. Usually, if you pick your changes and then run yarn lint, you'll manage to resolve them pretty quickly.

You are 100% right, but still...
will prefer to do it a bit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtemHoruzhenko ArtemHoruzhenko ArtemHoruzhenko requested changes

@valkirilov valkirilov valkirilov left review comments

@KrumTy KrumTy Awaiting requested review from KrumTy KrumTy is a code owner

@dantovska dantovska Awaiting requested review from dantovska dantovska is a code owner

@pd-redis pd-redis Awaiting requested review from pd-redis pd-redis is a code owner

Assignees

@pawelangelow pawelangelow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pawelangelow @ArtemHoruzhenko @valkirilov