refactor: convert sentinel column definitions to "static" definition #5221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to static objects - Move column definitions from column-definitions/ to components/columns/ - Convert factory functions to static ColumnDef objects - Refactor cell components to use meta.action pattern with getMetaAction helper - Add ColumnMeta.action type augmentation for dynamic callbacks - Simplify getColumns by inlining column definitions
Contributor
Code Coverage - Frontend unit tests
Test suite run success5411 tests passing in 702 suites. Report generated by 🧪jest coverage report action from 4cf6128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored Sentinel database column definitions from factory functions to static
ColumnDefobjects. Moved column definitions fromcolumn-definitions/tocomponents/columns/for better organization. Introducedmeta.actionpattern withgetMetaActionhelper to handle dynamic callbacks (e.g.,handleChangedInput) without passing props through cell components. AddedColumnMeta.actiontype augmentation to support flexible function signatures.Tech decisions:
meta.actionpattern decouples cell components from parent callbacksgetMetaActionhelper provides type-safe access to column metadataTesting
meta.actionpattern