Skip to content

Conversation

@valkirilov
Copy link
Member

@valkirilov valkirilov commented Dec 2, 2025

What

Make the badges for the keys in the browser, to remain readable once the key is selected (on light theme).

Note: This component needs refactoring, because there are plenty of SASS styles that should be dropped.

image

Testing

  1. Open Redis Insight and go to the Databases tab
  2. Open existing database connection, or establish a new one
  3. Make sure you have keys in this database (execute SET hello world in the CLI)
  4. Click on the key in the left panel on the Browser page

Observe the colors of the badge when the key is selected. It should remain readable.

Before After
Screenshot 2025-12-02 at 14 15 21 Screenshot 2025-12-02 at 14 14 55
Screenshot 2025-12-02 at 14 15 25 Screenshot 2025-12-02 at 14 15 00

Note

Removes the .nodeSelected .nodeContent * color override so selected key badges keep readable colors while retaining active background and border.

  • UI/Styles:
    • In redisinsight/ui/src/pages/browser/components/virtual-tree/components/Node/styles.module.scss, remove nodeSelected .nodeContent * { color: var(--euiColorFullShade) !important; } to avoid forcing text color on selected items.
    • Selection styling (border-left-color, background-color) remains unchanged.

Written by Cursor Bugbot for commit dd8c534. This will update automatically on new commits. Configure here.

…te for the keys badges in the browser

re #RI-7766
@valkirilov valkirilov marked this pull request as ready for review December 2, 2025 12:19
@valkirilov valkirilov changed the title RI-7766 Remove old color override conflicting with the selected selected state for the keys badges in the browser RI-7766 Remove old color override conflicting with the selected state for the keys badges in the browser Dec 2, 2025
@valkirilov valkirilov changed the title RI-7766 Remove old color override conflicting with the selected state for the keys badges in the browser RI-7766 Remove old color override for the the selected state of the keys badges Dec 2, 2025
@valkirilov valkirilov changed the title RI-7766 Remove old color override for the the selected state of the keys badges RI-7766 Remove old color override for the selected state of the keys badges Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.89% 21021/25360
🟡 Branches 68.06% 8847/12999
🟡 Functions 78.04% 5757/7377
🟢 Lines 83.3% 20587/24715

Test suite run success

5468 tests passing in 703 suites.

Report generated by 🧪jest coverage report action from dd8c534

@valkirilov valkirilov merged commit 149778b into release/3.0.0 Dec 2, 2025
15 checks passed
@valkirilov valkirilov deleted the fe/bigfix/RI-7766/browser-selected-keys-badge branch December 2, 2025 12:32
valkirilov added a commit that referenced this pull request Dec 3, 2025
…e for the keys badges in the browser (#5292)

re #RI-7766
valkirilov added a commit that referenced this pull request Dec 4, 2025
…e for the keys badges in the browser (#5292)

re #RI-7766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants