ci(ghcr): add deploy on GitHub #441
Conversation
| context: . | ||
| push: true | ||
| tags: | | ||
| ghcr.io/${{ github.repository_owner }}/redis:latest |
There was a problem hiding this comment.
I think that we shouldn't set the tag to latest due to versioning scheme expectations which might cause confusion.
There was a problem hiding this comment.
Lets use the specific commit SHA only for the time being
|
|
||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
We should also trigger for release/* branches
There was a problem hiding this comment.
Ok, what we want ?
- Trigger on tags ?
- Trigger on master ?
- Trigger on release/* ?
There was a problem hiding this comment.
I think that we should trigger on pushes to master and release/* and tag with the commit SHA for the time being.
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Build and push Docker images |
There was a problem hiding this comment.
We provide various platforms for our images, and this action seems like it would only push the amd64 architecture. What do you think about adding the rest of the archs, like we do on Dockerhub?
|
Simple question why you don't use tags ? 🤔 |
@TartanLeGrand |
This pull request introduces a new GitHub Actions workflow to automate the publishing of Docker images to the GitHub Container Registry (GHCR). The workflow is triggered on pushes to the
mainbranch and includes steps for building and pushing Docker images.New GitHub Actions Workflow:
.github/workflows/publish-to-ghcr.yml: Added a workflow named "Publish Docker Images to GHCR" that builds and pushes Docker images to GHCR. It includes steps for checking out the repository, logging into GHCR, setting up QEMU and Docker Buildx, and building and pushing Docker images with appropriate tags.