Skip to content

RDSC-3566: Improving documentation for data denormalization #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ilianiliev-redis
Copy link
Contributor

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions, but mostly looks good.

@ilianiliev-redis ilianiliev-redis requested a review from yaronp68 May 27, 2025 09:57
ilianiliev-redis and others added 6 commits June 4, 2025 14:23
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
@ilianiliev-redis ilianiliev-redis force-pushed the RDSC-3566-data-denormalisation-docs-improvement branch from 06fc7c5 to 31516c9 Compare June 4, 2025 12:17
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but otherwise LGTM.

ilianiliev-redis and others added 9 commits June 4, 2025 15:51
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
…enormalization.md

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
@ilianiliev-redis
Copy link
Contributor Author

@andy-stark-redis I have added all your suggestions, and it is good to go.

@andy-stark-redis andy-stark-redis merged commit d762fd6 into redis:main Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants