DOC-4990 AMR connection page for Go #1605
Conversation
|
Thanks @dwdougherty ! |
There was a problem hiding this comment.
@andy-stark-redis I am leaving some suggestions as a first review of this page. Ping me to do a final one when you review the suggestions.
content/develop/clients/go/amr.md
Outdated
| clientID := os.Getenv("AZURE_CLIENT_ID") | ||
| redisEndpoint := os.Getenv("REDIS_ENDPOINT") | ||
| if clientID == "" || redisEndpoint == "" { | ||
| log.Fatal( | ||
| "AZURE_CLIENT_ID and REDIS_ENDPOINT env variables are required" | ||
| ) | ||
| } |
There was a problem hiding this comment.
client id is not needed for system assigned identity provider
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
|
@ndyakov Thanks for the review. I've implemented your suggestions - please let me know if there's anything else that needs to be changed. |
| . | ||
| . | ||
| provider, err := entraid.NewConfidentialCredentialsProvider( | ||
| entraid.ConfidentialIdentityProviderOptions{ |
There was a problem hiding this comment.
| entraid.ConfidentialIdentityProviderOptions{ | |
| entraid.ConfidentialCredentialsProviderOptions{ |
There was a problem hiding this comment.
My bad, probably mistyped this in the last review.
| }, | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@andy-stark-redis do you think it will be beneficial to have a complete example on where those options are supposed to be passed?
For example, just after initiating this options variable, have something like :
provider, err := entraid.NewManagedIdentityCredentialsProvider(
entraid.ManagedIdentityCredentialsProviderOptions{
CredentialsProviderOptions: options,
ManagedIdentityProviderOptions: identity.ManagedIdentityProviderOptions{
ManagedIdentityType: identity.UserAssignedObjectID,
UserAssignedObjectID: "<your-user-assigned-client-id>",
},
},
)
DOC-4990
This (hopefully) gives Go about the same level of detail as the Jedis AMR docs.
All feedback is welcome, but a few things to note:
AuthorityTypeMultiTenant= "multi-tenant") but let me know if it's better not to do this.