Add command SMISMEMBER #1742
Add command SMISMEMBER #1742
Conversation
| SInter(ctx context.Context, keys ...string) *StringSliceCmd | ||
| SInterStore(ctx context.Context, destination string, keys ...string) *IntCmd | ||
| SIsMember(ctx context.Context, key string, member interface{}) *BoolCmd | ||
| SMIsMember(ctx context.Context, key string, members ...interface{}) *BoolSliceCmd |
There was a problem hiding this comment.
I believe we should change SIsMember to accept multiple args and use smismember if len(members) > 1. What do you think?
There was a problem hiding this comment.
I understand that these two commands are quite similar, but changing SIsMember to accept multiple args breaks the API compatibility. The current type of return value is *BoolCmd, while the desired is *BoolSliceCmd.
There was a problem hiding this comment.
Can we consider modifying it in v9? they function exactly the same.
There was a problem hiding this comment.
This looks acceptable to me.
I can modify the SIsMember and open another PR to branch v9 after you draw the conclusion.
There was a problem hiding this comment.
I haven't realized they return different results. No need to merge them then.
3 participants
No description provided.