Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLIENT SETINFO #2553

Closed
wants to merge 1 commit into from

Conversation

SoulPancake
Copy link
Contributor

@SoulPancake
Copy link
Contributor Author

@monkey92t Would we consider merging #2483 before continuing on this
As it can be useful to test this command
Or alternatively do you have a suggestion on how we can test this?

@monkey92t
Copy link
Collaborator

CLIENT-SETINFO is similar to #2492, it represents the state of the connection, not just the command.

What do you think we should do?

@SoulPancake
Copy link
Contributor Author

According to the docs
We should be able to test these by checking whether those version/fields are there in the client info right?

@monkey92t
Copy link
Collaborator

It is tied to the network connection...

client -> call cmd -> conn-1 -> client setinfo lib-name test-name
client -> call cmd -> conn-2 -> client info -> lib-name ->""

Because we only set lib-name for conn-1, when we execute client-info, unless we are lucky and conn-1 is selected in the connection pool, we cannot get the value of lib-name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new redis command CLIENT SETINFO
2 participants