Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update command.go #2684

Closed
wants to merge 3 commits into from
Closed

Update command.go #2684

wants to merge 3 commits into from

Conversation

liuqian1990
Copy link

https://redis.io/commands/slowlog-get/

The unit of data obtained by slowlog get itself is already us, no further conversion is required

liuqian1990 and others added 3 commits August 29, 2023 17:16
@liuqian1990
Update command.go
c083fe4 
https://redis.io/commands/slowlog-get/

The unit of data obtained by slowlog get itself is already us, no further conversion is required
@ofekshenawa
Merge branch 'master' into master
06856fe
@liuqian1990
Merge branch 'master' into master
015cc63
@ofekshenawa
Copy link
Collaborator

Hey,
Thank you for your contribution and for bringing this to our attention. However, according to the Redis command reference here, the slowlog get command returns the execution time in microseconds, not nanoseconds.
The documentation specifically states: "The amount of time needed for its execution, in microseconds.

WDYT?

@liuqian1990 liuqian1990 closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofekshenawa ofekshenawa Awaiting requested review from ofekshenawa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuqian1990 @ofekshenawa