change interfaces probabilistic and redis gears from private to public #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why go 1.20.x tests are failing EDIT: thanks @ofekshenawa |
|
Cross linking #2701 for visibility, since they're tied together. |
chayim
previously approved these changes
Sep 11, 2023
peczenyj
changed the title
ofekshenawa
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, if we look into
UniversalClientinterface documentation,https://pkg.go.dev/github.com/redis/go-redis/v9#UniversalClient
it includes the
Cmdableinterfacehttps://pkg.go.dev/github.com/redis/go-redis/v9#Cmdable
however we have no mention or link to the methods defined in gears or probabilistic interfaces because such interfaces are private.