RediSearch Support #2801
RediSearch Support #2801
Conversation
Ref: https://github.com/redis/go-redis/blob/e3d522fef42f0e0dea0ac228cefaac65df2f0e41/search_test.go redis/go-redis#2801 Signed-off-by: Steve ESSO <stivesso@gmail.com>
|
how is this mr going？ |
ofekshenawa
force-pushed
the
search-support
branch
from
ff062db
to
0809062
Compare
|
@ofekshenawa @vladvildanov @chayim @jiangtao244 hi guys, sorry for interrupting, we stucked with using RediSearch in golang, under RESP3 protocol, especially with I found that RESP3 testing code was commented for some reason, so in production it doesn't work at all (incorrect response parsing) — any luck with supporting third version of protocol? If there is no pull request which fixes that problem, I created a fork with completed implementation of supporting "new" version of response, should I create a pull request for that? |
|
@quenbyako Thank you for reaching us out! Sorry for the bad experience, but we had to rollback our latest release that brings a support for RediSearch, so this functionality is considered non-finished. We're planning to release it very soon, but on the first stage it will be RESP2 only, RESP3 support will be a part of the release after this. Stay tuned for update in near future! |
|
@vladvildanov Glad that you responded so quick, thank you 😊🙏 Regarding to features rollback: Was this lack of compatibility for RESP3 documented somewhere? Cause I spent yesterday nearly 5 hours to undestand what's happened, and it was hell, there is completely no info about this one... I implemented quick and dirty support for |
|
@quenbyako The RESP3 will be partially compatible in near future and will be explained in the statement we prepare for community. We apologise that it forced you to dig into it, it was totally not planned to release it "that" way. We promise to properly communicate it with you 👌 |
|
@quenbyako Join our discord community, there's a channel dedicated to go-redis as well https://discord.gg/zhvcaDMc |
|
Hi @vladvildanov any update about this? |
|
@quenbyako Hey! Sorry for the delay, we're about to release Search support along with JSON in RESP2, will be included into next release |
|
Hi @vladvildanov, Is there any ongoing issue that I can track for progress? Not able to join discord invite that was shared above too |
|
@sainad2222 Hey! Search support has been released and it's a part of 9.7.0 |
No description provided.