Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node routing in slotClosestNode #3043

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

srikar-jilugu
Copy link
Contributor

No description provided.

@srikar-jilugu
Copy link
Contributor Author

@monkey92t please review this fix for the issue:#3023

Copy link
Collaborator

@monkey92t monkey92t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but using the nearest node each time will put a lot of stress on that node. We can optimize it further later.

@monkey92t monkey92t merged commit 9c1f4f0 into redis:master Jul 10, 2024
10 checks passed
@srikar-jilugu
Copy link
Contributor Author

@monkey92t when can we expect the next release?

@monkey92t
Copy link
Collaborator

@monkey92t when can we expect the next release?

v9.5.3

@srikar-jilugu
Copy link
Contributor Author

v9.5.3

@monkey92t this release doesn't include commits of this pr

@monkey92t
Copy link
Collaborator

v9.5.3

@monkey92t this release doesn't include commits of this pr

Changes

???

@srikar-jilugu
Copy link
Contributor Author

func (c *clusterState) slotClosestNode(slot int) (*clusterNode, error) {

The commits are there in master branch, but the release seems to be behind it

@srikar-jilugu
Copy link
Contributor Author

v9.5.2...v9.5.3

@monkey92t
Copy link
Collaborator

It seems to have been affected. I'll take a look.

@monkey92t
Copy link
Collaborator

@srikar-jilugu I've added a new version. v9.5.4

@srikar-jilugu
Copy link
Contributor Author

@srikar-jilugu I've added a new version. v9.5.4

Thankyou!

vladvildanov pushed a commit that referenced this pull request Jul 17, 2024
* fix node routing when all nodes are failing

* fix minlatency zero value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants