Avoid unnecessary retry delay in cluster client following MOVED and ASK redirection #3048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOVED
andASK
responses during command execution in a cluster mode client are not indicative of transient errors for which the client should gracefully delay before a retry. The current behavior unnecessarily constraints throughput in scenarios where:CLUSTER SLOTS
loadThese effects are particularly pronounced at scale, when
MinRetryBackoff
is high.This PR proposes exemption of these classes of errors during the
MaxRedirects
loop.Consider the following example benchmark, which uses all default configuration options:
Current behavior, without this patch:
With this patch: