Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json resp 2 #3146

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Support json resp 2 #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56bcaaa
Support ReJSON resp 2 && Test ReJSON against RESP 2 and 3 && Add comp…
ofekshenawa Oct 7, 2024
e2e570e
Remove comments
ofekshenawa Oct 7, 2024
093a3d2
Merge branch 'master' into support-json-resp-2
ofekshenawa Oct 7, 2024
affdd96
Merge branch 'master' into support-json-resp-2
ofekshenawa Oct 9, 2024
43669ce
Remove unnecessary changes
ofekshenawa Oct 9, 2024
0432981
Merge branch 'master' of https://github.com/redis/go-redis into suppo…
ofekshenawa Oct 9, 2024
51ceeb5
Merge branch 'support-json-resp-2' of https://github.com/redis/go-red…
ofekshenawa Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ type JSONArrTrimArgs struct {
type JSONCmd struct {
baseCmd
val string
expanded []interface{}
expanded interface{}
vladvildanov marked this conversation as resolved.
Show resolved Hide resolved
}

var _ Cmder = (*JSONCmd)(nil)
Expand Down Expand Up @@ -100,11 +100,11 @@ func (cmd *JSONCmd) Result() (string, error) {
return cmd.Val(), cmd.Err()
}

func (cmd JSONCmd) Expanded() (interface{}, error) {
func (cmd *JSONCmd) Expanded() (interface{}, error) {
if len(cmd.val) != 0 && cmd.expanded == nil {
err := json.Unmarshal([]byte(cmd.val), &cmd.expanded)
if err != nil {
return "", err
return nil, err
}
}

Expand Down Expand Up @@ -494,7 +494,7 @@ func (c cmdable) JSONMSet(ctx context.Context, params ...interface{}) *StatusCmd
}

// JSONNumIncrBy increments the number value stored at the specified path by the provided number.
// For more information, see https://redis.io/commands/json.numincreby
// For more information, see https://redis.io/docs/latest/commands/json.numincrby/
func (c cmdable) JSONNumIncrBy(ctx context.Context, key, path string, value float64) *JSONCmd {
args := []interface{}{"JSON.NUMINCRBY", key, path, value}
cmd := newJSONCmd(ctx, args...)
Expand Down
Loading
Loading