fix(ring): Pipelined returns error when shard is down #3417
+41
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#3402
Problem
When a shard in a Ringis unreachable due to a network issue or a low DialTimeout、
•.'Ring.Pipelined () would not return an error. Instead, it failed silently, giving the false impression that the pipelined commands were successfully executed. This behavior was inconsistent with 'Client.Pipelined () and could lead to undetected data loss.
Solution
This change modifies the
generalProcessPipeline
function to correctly handle and propagate errors.sync.Mutex
is used to ensure thread-safe error reporting| from the concurrent shard operations.A new test case has also been added to verify that Pipelined () 、returns a
dial
error when a shard is unreachable, preventing future regressions.