Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

io.js support #72

Closed
wants to merge 1 commit into from
Closed

io.js support #72

wants to merge 1 commit into from

Conversation

timoxley
Copy link

Updates nan's minimum version to 1.5.1 which enables hiredis to build on io.js.

Tests pass minus the already failing LargeIntegerReply test:

// This test fails since v8 doesn't to 64-bit integers...
test("LargeIntegerReply", function() {
    var reader = new hiredis.Reader();
    reader.feed(":9223372036854775807\r\n");
    assert.equal("9223372036854775807", String(reader.get()));
});
> hiredis@0.1.17 test /Users/timoxley/Projects/libs/hiredis-node
> node test/reader.js

LargeIntegerReply failed!
AssertionError: "9223372036854775807" == "9223372036854776000"
    at /Users/timoxley/Projects/libs/hiredis-node/test/reader.js:47:12
    at test (/Users/timoxley/Projects/libs/hiredis-node/test/reader.js:9:9)
    at Object.<anonymous> (/Users/timoxley/Projects/libs/hiredis-node/test/reader.js:44:1)
    at Module._compile (module.js:446:26)
    at Object.Module._extensions..js (module.js:464:10)
    at Module.load (module.js:341:32)
    at Function.Module._load (module.js:296:12)
    at Function.Module.runMain (module.js:487:10)
    at startup (node.js:111:16)
    at node.js:809:3

Updates nan's minimum version to 1.5.1 which enables hiredis to build on
io.js.
@timoxley
Copy link
Author

Also note that Travis CI is yet to support io.js.

@timoxley
Copy link
Author

My bad, @jonathanong has already submitted this same PR #71

@timoxley timoxley closed this Jan 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant