Retry poll(2) if we are intterupted. #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logic to retry our poll call when waiting for the connection to complete, in the event that we are interrupted by a signal. Additionally we do some simple bookkeeping to keep track of the overall timeout specified by the user. Fixes #1206
Collaborator
Author
|
cc @yossigo Part of me thinks this is overkill but OTOH it seems like a good idea to respect the users's total requested connection timeout in the context of an interrupted sycall. |
yossigo
approved these changes
Jul 25, 2023
Member
yossigo
left a comment
yossigo
left a comment
There was a problem hiding this comment.
@michael-grunder LGTM. I agree this is somewhat overkill but I think it's the best way to handle it given the constraints of current API and our desire to minimize breaking changes. I think we should clearly document this behavior change, by the way.
michael-grunder
added a commit
that referenced
this pull request
Jul 25, 2023
michael-grunder
added a commit
that referenced
this pull request
Jul 25, 2023
michael-grunder
added a commit
that referenced
this pull request
Jul 25, 2023
This was referenced Oct 25, 2024
TedLyngmo
pushed a commit
to TedLyngmo/hiredis
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic to retry our poll call when waiting for the connection to complete, in the event that we are interrupted by a signal.
Additionally we do some simple bookkeeping to keep track of the overall timeout specified by the user.
Fixes #1206