Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove console.log #1883

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: remove console.log #1883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,6 @@
// this handler must run after the "data" handler in "DataHandler"
// so that `this.commandQueue.length` will be updated
this.stream.once("data", () => {
console.log('GOT DATA, CLEARING TIMER');
clearTimeout(this.socketTimeoutTimer);
this.socketTimeoutTimer = undefined;
if (this.commandQueue.length === 0) return;
Expand All @@ -559,35 +558,35 @@
});
}

scanStream(options?: ScanStreamOptions) {

Check warning on line 561 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member scanStream should be declared before all private instance method definitions

Check warning on line 561 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member scanStream should be declared before all private instance method definitions

Check warning on line 561 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member scanStream should be declared before all private instance method definitions

Check warning on line 561 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member scanStream should be declared before all private instance method definitions
return this.createScanStream("scan", { options });
}

scanBufferStream(options?: ScanStreamOptions) {

Check warning on line 565 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member scanBufferStream should be declared before all private instance method definitions

Check warning on line 565 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member scanBufferStream should be declared before all private instance method definitions

Check warning on line 565 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member scanBufferStream should be declared before all private instance method definitions

Check warning on line 565 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member scanBufferStream should be declared before all private instance method definitions
return this.createScanStream("scanBuffer", { options });
}

sscanStream(key: string, options?: ScanStreamOptions) {

Check warning on line 569 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member sscanStream should be declared before all private instance method definitions

Check warning on line 569 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member sscanStream should be declared before all private instance method definitions

Check warning on line 569 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member sscanStream should be declared before all private instance method definitions

Check warning on line 569 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member sscanStream should be declared before all private instance method definitions
return this.createScanStream("sscan", { key, options });
}

sscanBufferStream(key: string, options?: ScanStreamOptions) {

Check warning on line 573 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member sscanBufferStream should be declared before all private instance method definitions

Check warning on line 573 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member sscanBufferStream should be declared before all private instance method definitions

Check warning on line 573 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member sscanBufferStream should be declared before all private instance method definitions

Check warning on line 573 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member sscanBufferStream should be declared before all private instance method definitions
return this.createScanStream("sscanBuffer", { key, options });
}

hscanStream(key: string, options?: ScanStreamOptions) {

Check warning on line 577 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member hscanStream should be declared before all private instance method definitions

Check warning on line 577 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member hscanStream should be declared before all private instance method definitions

Check warning on line 577 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member hscanStream should be declared before all private instance method definitions

Check warning on line 577 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member hscanStream should be declared before all private instance method definitions
return this.createScanStream("hscan", { key, options });
}

hscanBufferStream(key: string, options?: ScanStreamOptions) {

Check warning on line 581 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member hscanBufferStream should be declared before all private instance method definitions

Check warning on line 581 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member hscanBufferStream should be declared before all private instance method definitions

Check warning on line 581 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member hscanBufferStream should be declared before all private instance method definitions

Check warning on line 581 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member hscanBufferStream should be declared before all private instance method definitions
return this.createScanStream("hscanBuffer", { key, options });
}

zscanStream(key: string, options?: ScanStreamOptions) {

Check warning on line 585 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member zscanStream should be declared before all private instance method definitions

Check warning on line 585 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member zscanStream should be declared before all private instance method definitions

Check warning on line 585 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member zscanStream should be declared before all private instance method definitions

Check warning on line 585 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member zscanStream should be declared before all private instance method definitions
return this.createScanStream("zscan", { key, options });
}

zscanBufferStream(key: string, options?: ScanStreamOptions) {

Check warning on line 589 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member zscanBufferStream should be declared before all private instance method definitions

Check warning on line 589 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member zscanBufferStream should be declared before all private instance method definitions

Check warning on line 589 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member zscanBufferStream should be declared before all private instance method definitions

Check warning on line 589 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member zscanBufferStream should be declared before all private instance method definitions
return this.createScanStream("zscanBuffer", { key, options });
}

Expand All @@ -596,7 +595,7 @@
*
* @ignore
*/
silentEmit(eventName: string, arg?: unknown): boolean {

Check warning on line 598 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member silentEmit should be declared before all private instance method definitions

Check warning on line 598 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member silentEmit should be declared before all private instance method definitions

Check warning on line 598 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member silentEmit should be declared before all private instance method definitions

Check warning on line 598 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member silentEmit should be declared before all private instance method definitions
let error: unknown;
if (eventName === "error") {
error = arg;
Expand Down Expand Up @@ -631,7 +630,7 @@
/**
* @ignore
*/
recoverFromFatalError(

Check warning on line 633 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (12.x) 

Member recoverFromFatalError should be declared before all private instance method definitions

Check warning on line 633 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (14.x) 

Member recoverFromFatalError should be declared before all private instance method definitions

Check warning on line 633 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (16.x) 

Member recoverFromFatalError should be declared before all private instance method definitions

Check warning on line 633 in lib/Redis.ts

View workflow job for this annotation

GitHub Actions / test / test (18.x) 

Member recoverFromFatalError should be declared before all private instance method definitions
_commandError: Error,
err: Error,
options: FlushQueueOptions
Expand Down
Loading