-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(example): add example for setting TTL to "HSET Field" #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
would make sense to have an example here.
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ironnicko, thank you for the contribution. That's a good idea, however, running the examples now results in an error ReplyError: WRONGTYPE Operation against a key holding the wrong kind of value.
Additionally, it would be nice to include a console.log that shows the ttl like the other examples:
console.log(await redis.call("httl", "hfoo", "FIELDS", "1", "bar")); // 10There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks for the feedback. |
|
🎉 This PR is included in version 5.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* origin/main: chore(release): 5.8.2 [skip ci] fix: move CLIENT SETINFO commands to connection handshake (redis#2033) ci(test): add redis matrix and update docker compose file (redis#2034) docs(example): add example for setting TTL to "HSET Field" (redis#2027) fix: default IP family selection to 0 (redis#2028) chore(release): 5.8.1 [skip ci] test: add scenario tests v5 (redis#2020) fix(ssubscribe): re-subscribe sharded pubsub channels individually (redis#2021) chore(release): 5.8.0 [skip ci] feat: support client setinfo (redis#2011) feat(stream): Add XDELEX command (redis#2003) Add stale issue management workflow (redis#2018) feat: implement proper hpexpire command signatures and tests (redis#2006) feat: add more xtrim method overloads and tests (redis#2010) test(cluster): fix and add cluster tests in CI (redis#2017) Force slots refresh on MOVED error when using ssubscribe (redis#2013) fix(ssubscribe): re-subscribe sharded pubsub channels individually on ready (redis#2012) chore(release): 5.7.0 [skip ci] fix: xread example for TypeScript (redis#1872) feat: Implement hexpire for redis#1898 (redis#1918)
would make sense to have an example here.