Fix: client setname need ignore syntax error in redis4 (#3411)

redis · May 17, 2023 · 65d47fc · 65d47fc
1 parent 8e6a709
commit 65d47fc
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/main/java/redis/clients/jedis/Connection.java b/src/main/java/redis/clients/jedis/Connection.java
@@ -398,7 +398,14 @@ private void initializeFromClientConfig(JedisClientConfig config) {
         if (obj instanceof JedisDataException) {
           JedisDataException e = (JedisDataException)obj;
           String errorMsg = e.getMessage().toUpperCase();
-          if (errorMsg.contains("UNKNOWN") ||
+          /**
+           * 1. Redis 4.0 and before, we need to ignore `Syntax error`.
+           * 2. Redis 5.0 and later, we need to ignore `Unknown subcommand error`.
+           * 3. Because Jedis allows Jedis jedis = new Jedis() in advance, and jedis.auth(password) later,
+           * we need to ignore `NOAUTH errors`.
+           */
+          if (errorMsg.contains("SYNTAX") ||
+              errorMsg.contains("UNKNOWN") ||
               errorMsg.contains("NOAUTH")) { // TODO: not filter out NOAUTH
             // ignore
           } else {