Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to GitHub Actions from CircleCI #2975

Merged
merged 31 commits into from
Apr 12, 2022
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Apr 10, 2022

This PR removes CircleCI and runs our actions on GitHub (hence the failing CI check). As part of this PR, maven snapshots are split out, to run upon a successful merge (and tests) against an integration branch such as master, or a versioned branch (eg 4.0).

These rules only take effect, once merged into the appropriate branch.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #2975 (0244b64) into master (3c18734) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 0244b64 differs from pull request most recent head ae27a10. Consider uploading reports for the commit ae27a10 to get more accurate results

@@             Coverage Diff              @@
##             master    #2975      +/-   ##
============================================
- Coverage     53.56%   53.45%   -0.11%     
+ Complexity     3332     3330       -2     
============================================
  Files           216      216              
  Lines         13298    13298              
  Branches        774      774              
============================================
- Hits           7123     7109      -14     
- Misses         5927     5942      +15     
+ Partials        248      247       -1     
Impacted Files Coverage Δ
...ava/redis/clients/jedis/params/FailoverParams.java 89.47% <0.00%> (-10.53%) ⬇️
...in/java/redis/clients/jedis/JedisSentinelPool.java 65.89% <0.00%> (-5.79%) ⬇️
...rc/main/java/redis/clients/jedis/JedisFactory.java 66.32% <0.00%> (-2.05%) ⬇️
src/main/java/redis/clients/jedis/Jedis.java 84.92% <0.00%> (-0.10%) ⬇️
...redis/clients/jedis/DefaultJedisSocketFactory.java 96.05% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c18734...ae27a10. Read the comment docs.

@chayim chayim marked this pull request as ready for review April 11, 2022 10:41
@chayim chayim requested a review from sazzad16 April 11, 2022 10:41
@chayim chayim changed the title moving to actions Migrating to GitHub Actions from CircleCI Apr 12, 2022
@chayim chayim merged commit a2969a4 into redis:master Apr 12, 2022
@chayim chayim deleted the ck-ghactions branch April 12, 2022 10:16
chayim added a commit to chayim/jedis that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants