Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce factory MINIMUM_ID and MAXIMUM_ID for StreamEntryID #3006

Merged
merged 1 commit into from
May 29, 2022

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented May 29, 2022

Resolves #2648

@sazzad16 sazzad16 added this to the 4.3.0 milestone May 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3006 (2dc9514) into master (96968e4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3006      +/-   ##
============================================
+ Coverage     53.37%   53.42%   +0.05%     
  Complexity     3339     3339              
============================================
  Files           216      216              
  Lines         13343    13347       +4     
  Branches        775      775              
============================================
+ Hits           7122     7131       +9     
+ Misses         5975     5968       -7     
- Partials        246      248       +2     
Impacted Files Coverage Δ
...c/main/java/redis/clients/jedis/StreamEntryID.java 69.04% <100.00%> (+3.25%) ⬆️
src/main/java/redis/clients/jedis/JedisPubSub.java 70.00% <0.00%> (-1.82%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 88.12% <0.00%> (-1.25%) ⬇️
src/main/java/redis/clients/jedis/Jedis.java 84.97% <0.00%> (+0.04%) ⬆️
src/main/java/redis/clients/jedis/Connection.java 85.35% <0.00%> (+1.51%) ⬆️
...in/java/redis/clients/jedis/ConnectionFactory.java 67.34% <0.00%> (+4.08%) ⬆️
...ava/redis/clients/jedis/params/XPendingParams.java 68.08% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96968e4...2dc9514. Read the comment docs.

@sazzad16 sazzad16 merged commit dcebe09 into redis:master May 29, 2022
@sazzad16 sazzad16 deleted the x-min-max-id branch May 29, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add special stream IDs '-' (min) and '+' (max) in StreamEntryID
2 participants