Remove JedisBroadcast

[sazzad16]

No description provided.

[yangbodong22011]

@sazzad16 can you explain the reason?

[sazzad16]

@yangbodong22011 Product managers within Redis are not satisfied how error handling is looking with this approach (even though they are satisfied with actual broadcast). I feel there is a big chance of a future breaking request if we release this in 4.4.0 release and I'd prefer to avoid that. So I've created this PR as a reminder to remove this feature just in case we have to release 4.4.0 before the green signal of this broadcast approach.

[yangbodong22011]

Product managers within Redis are not satisfied how error handling is looking with this approach (even though they are satisfied with actual broadcast).

Did they provide their own ideas or plans? Directly modify the command of JedisCluster itself or other?

I feel there is a big chance of a future breaking request if we release this in 4.4.0 release and I'd prefer to avoid that.

It will not bring breaking change, it's a new feature and we did not change the default behavior of original Commands.

[sazzad16]

Did they provide their own ideas or plans? Directly modify the command of JedisCluster itself or other?

I'm waiting for that.

It will not bring breaking change, it's a new feature and we did not change the default behavior of original Commands.

Introducing it is not the breaking change. I meant releasing JedisBroadcast in 4.4.0 and then possibly breaking it in immediate/later release.

[codecov-commenter]

Codecov Report

Base: 66.95% // Head: 67.00% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (25689dc) compared to base (c4506e4).
Patch has no changes to coverable lines.

❗ Current head 25689dc differs from pull request most recent head e4f71ce. Consider uploading reports for the commit e4f71ce to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3254      +/-   ##
============================================
+ Coverage     66.95%   67.00%   +0.04%     
+ Complexity     4640     4622      -18     
============================================
  Files           258      256       -2     
  Lines         15027    14946      -81     
  Branches        938      935       -3     
============================================
- Hits          10062    10015      -47     
+ Misses         4562     4531      -31     
+ Partials        403      400       -3     

Impacted Files	Coverage Δ
...rc/main/java/redis/clients/jedis/UnifiedJedis.java	75.26% <ø> (-0.03%)	⬇️
...nts/jedis/providers/ClusterConnectionProvider.java	79.03% <ø> (-0.34%)	⬇️
...ents/jedis/providers/PooledConnectionProvider.java	100.00% <ø> (ø)
...nts/jedis/providers/ShardedConnectionProvider.java	76.05% <ø> (+1.05%)	⬆️
...in/java/redis/clients/jedis/BroadcastResponse.java	0.00% <0.00%> (-54.55%)	⬇️
src/main/java/redis/clients/jedis/JedisPubSub.java	70.00% <0.00%> (-1.82%)	⬇️
src/main/java/redis/clients/jedis/Connection.java	83.83% <0.00%> (-1.52%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sazzad16]

Resolved by #3285