-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub handle array of messages #3512
Pubsub handle array of messages #3512
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3512 +/- ##
============================================
- Coverage 82.13% 82.10% -0.03%
- Complexity 6016 6017 +1
============================================
Files 301 301
Lines 15273 15282 +9
Branches 1190 1193 +3
============================================
+ Hits 12544 12547 +3
- Misses 2162 2163 +1
- Partials 567 572 +5 ☔ View full report in Codecov by Sentry. |
@sankarcheppali Why do you want this change? Are you implementing client side caching for yourself? |
Hello @sazzad16 , yes this is for client side caching. |
@sankarcheppali Where? Would you implement client side caching only for your application or for Jedis? |
Hi, I am trying to implement in my application, and when I register for the invalidation channel, the code is failing due to type casting issue. |
Hi @sazzad16 , I would also like to backport this to 3.x, Please let me know if this is acceptable. |
Please feel free to submit a pull request! But, client side caching is planned for an upcoming release of Jedis. Of course, you'll need to use a more recent version, as that occurs. |
Resolved by #3811 |
Thank you @sankarcheppali for this PR. This helped me writing the tests in #3811 |
For client tracking, redis sends array instead of a single message (handled this by checking the instance of the bmesg before casting it to byte array)
https://redis.io/docs/manual/client-side-caching/