[automatic failover] Add dual thresholds (min num of failures + failure rate) capabililty to circuit breaker #4295

atakavci · 2025-09-26T17:21:22Z

Summary

Introduce dual-threshold circuit-breaker failover for Jedis multi‑cluster, simplify configuration, and align docs/tests. Failover now occurs only when BOTH of the following are exceeded: minimum number of failures and failure‑rate percentage.

Key changes

Dual-threshold enforcement
- New evaluation in CircuitBreakerFailoverBase: evaluateThresholds(cluster) checks metrics and opens the CB when thresholds are exceeded; clusterFailover(...) then forces open and switches clusters.
- CircuitBreakerCommandExecutor and CircuitBreakerFailoverConnectionProvider now call evaluateThresholds before execution and on tracked exceptions to keep decisions consistent and deterministic.
New CircuitBreakerThresholdsAdapter
- Maps MultiClusterClientConfig → resilience4j CircuitBreakerConfig.
- Special handling:
  - failureRateThreshold = 0.0f maps to 100.0f (resilience4j limitation).
  - minimumNumberOfCalls is derived from configured minFailures and rate; when rate == 0.0f, sets Integer.MAX_VALUE to prevent the CB from auto-opening on its own.
  - Uses TIME_BASED window; size comes from config.
MultiClusterClientConfig simplification and new defaults
- Added circuitBreakerMinNumOfFailures (default 1000) and validation that rejects both minFailures==0 and rate==0 simultaneously.
- Defaults updated: failureRateThreshold=10.0f, slidingWindowSize=2.
- Removed slow-call knobs (duration and rate) and sliding-window type/min-calls from the public API.
MultiClusterPooledConnectionProvider
- Builds the CircuitBreaker using CircuitBreakerThresholdsAdapter.
- Exposes cluster getters for getCircuitBreakerMinNumOfFailures() and getCircuitBreakerFailureRateThreshold().
Documentation
- Updated failover.md to the new defaults and simplified table; removed slow-call and sliding window type/min-calls; clarified the dual-threshold model.
Tests
- New CircuitBreakerFailoverBaseTests: matrix coverage of minFailures × failure-rate using real CB metrics with mocked wiring.
- New/updated CircuitBreakerThresholdsTest: exercises real provider + real executor + real CB/Retry with only the connection pool mocked (no network), validating threshold behavior and failover switching.
- Integration tests (FailoverIntegrationTest, ActiveActiveLocalFailoverTest) adjusted to the new configuration style and defaults.

Behavior

Failover is triggered when BOTH conditions hold:

failures >= circuitBreakerMinNumOfFailures
(failed / (failed + successful)) × 100 >= circuitBreakerFailureRateThreshold

Notes

With failureRateThreshold=0.0f, adapter maps to 100.0f and sets minimumNumberOfCalls=Integer.MAX_VALUE so resilience4j does not auto-open; Jedis still enforces the dual-threshold policy in the executor/base.
Automatic transition from OPEN to HALF_OPEN remains disabled; failback is handled by existing health‑check/failback mechanisms.

Migration

Use these settings:

circuitBreakerMinNumOfFailures(int)
circuitBreakerFailureRateThreshold(float)
circuitBreakerSlidingWindowSize(int) // time-based seconds

Removed settings (no longer applicable):

slidingWindowType, slidingWindowMinCalls
slowCallDurationThreshold, slowCallRateThreshold

If you previously relied on slow-call based opening, migrate to failure-based thresholds or external performance monitors.

Validation

Unit/parameterized tests cover edge thresholds (0%, 100%), small/large sample sizes.
Integration tests updated to the new API; docs reflect defaults and examples.
CircuitBreakerThresholdsTest now validates end‑to‑end interaction among provider + executor + circuit breaker without using network calls.

…aiters()' in 'TrackingConnectionPool' (redis#4270) - remove the check for number of waitiers in TrackingConnectionPool

…redis#4268) - set maxtotal connections for echoStrategy

…cuitBreakerFailoverBase.clusterFailover' (redis#4275) * - replace CircuitBreaker with Cluster for CircuitBreakerFailoverBase.clusterFailover - improve thread safety with provider initialization * - formatting

* - minor optimizations on fail fast * - volatile failfast

* - replace minConsecutiveSuccessCount with numberOfRetries - add retries into healtCheckImpl - apply changes to strategy implementations config classes - fix unit tests * - fix typo * - fix failing tests * - add tests for retry logic * - formatting * - format * - revisit numRetries for healthCheck ,replace with numProbes and implement built in policies - new types probecontext, ProbePolicy, HealthProbeContext - add delayer executor pool to healthcheckımpl - adjustments on worker pool of healthCheckImpl for shared use of workers * - format * - expand comment with example case * - drop pooled executor for delays * - polish * - fix tests * - formatting * - checking failing tests * - fix test * - fix flaky tests * - fix flaky test * - add tests for builtin probing policies * - fix flaky test

* - move failover provider to mcf * - make iterateActiveCluster package private

redis#4291) * User-provided ssl config for lag-aware health check * ssl scenario test for lag-aware healthcheck * format * format * address review comments - use getters instead of fields

…#4293) * - implement max failover attempt - add tests * - fix user receive the intended exception * -clean+format * - java doc for exceptions * format * - more tests on excaption types in max failover attempts mechanism * format * fix failing timing in test * disable health checks * rename to switchToHealthyCluster * format

…t breaker executor - Map config to resilience4j via CircuitBreakerThresholdsAdapter - clean up/simplfy config: drop slow-call and window type - Add thresholdMinNumOfFailures; update some of the defaults - Update provider to use thresholds adapter - Update docs; align examples with new defaults - Add tests for 0% rate, edge thresholds

jit-ci · 2025-09-26T17:21:27Z

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Copilot

Pull Request Overview

This PR adds dual-threshold failover capability to Jedis multi-cluster circuit breaker functionality. The circuit breaker now requires both a minimum number of failures AND a failure rate threshold to be exceeded before triggering failover, providing more robust failover control.

Key changes:

Introduces dual threshold logic requiring both minimum failures and failure rate criteria to be met
Simplifies configuration by removing deprecated circuit breaker settings and updating defaults
Adds new adapter class to handle threshold mapping to resilience4j configuration

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`MultiClusterClientConfig.java`	Updated configuration with new dual threshold properties and simplified circuit breaker settings
`CircuitBreakerThresholdsAdapter.java`	New adapter class for mapping configuration to resilience4j circuit breaker settings
`CircuitBreakerCommandExecutor.java`	Added dual threshold checking logic before triggering failover
`CircuitBreakerFailoverBase.java`	Base class with shared threshold validation logic
`JedisFailoverThresholdsExceededException.java`	New exception type for threshold-based failover
Various test files	Updated tests to remove deprecated configuration options and add threshold testing
`docs/failover.md`	Updated documentation with new defaults and simplified configuration

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsAdapter.java

src/main/java/redis/clients/jedis/mcf/CircuitBreakerFailoverBase.java

src/main/java/redis/clients/jedis/mcf/CircuitBreakerFailoverConnectionProvider.java

src/main/java/redis/clients/jedis/mcf/CircuitBreakerCommandExecutor.java

src/test/java/redis/clients/jedis/mcf/HealthCheckTest.java

…Adapter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…resholds

- simplfy executer and cbfailoverconnprovider - adjust config getters - fix failing tests due to COUNT_BASED -> TIME_BASED - new tests for thresholds calculations and impact on circuit state transitions

Copilot

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java

…o ali/aa-failover-cbthresholds

- add more test on threshold calculations - enable command line arg for overwriting surefire.excludedGroups

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/test/java/redis/clients/jedis/mcf/HealthCheckTest.java

src/main/java/redis/clients/jedis/mcf/MultiClusterPooledConnectionProvider.java

…components (redis#4298) * - set & test default values * - format * - fix tests failing due to changing defaults

…resholds

ggivo

Still going trough the complete review, have some initial questions

src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsAdapter.java

src/main/java/redis/clients/jedis/mcf/MultiClusterPooledConnectionProvider.java

src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsAdapter.java

src/main/java/redis/clients/jedis/mcf/CircuitBreakerCommandExecutor.java

- add docs and more explanantion

ggivo · 2025-10-03T05:38:34Z

src/main/java/redis/clients/jedis/mcf/MultiClusterPooledConnectionProvider.java

+      Metrics metrics = cluster.getCircuitBreaker().getMetrics();
+      // ATTENTION: this is to increment fails in regard to the current call that is failing,
+      // DO NOT remove the increment, it will change the behaviour in case of initial requests to
+      // cluster fail
+      int fails = metrics.getNumberOfFailedCalls() + (lastFailRecorded ? 0 : 1);


Not sure I get this one.
In which case, metrics are not increased yet?

src/main/java/redis/clients/jedis/MultiClusterClientConfig.java

src/test/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsTest.java

ggivo

Some of the new properties need to be renamed to align the naming with the design:

circuitBreakerMinNumOfFailures(int) -> minNumOfFailuresThreshold
circuitBreakerFailureRateThreshold(float) -> failureRateThreshold
circuitBreakerSlidingWindowSize(int) -> failureDetectionWindowSize

We need to drop also circuitBreaker prefix from others.
Probably with follow-up PR?

…resholds

ggivo

LGTM

…4306) * [automatic failover] Set and test default values for failover config&components (#4298) * - set & test default values * - format * - fix tests failing due to changing defaults * [automatic failover] Add dual thresholds (min num of failures + failure rate) capabililty to circuit breaker (#4295) * [automatic failover] Remove the check for 'GenericObjectPool.getNumWaiters()' in 'TrackingConnectionPool' (#4270) - remove the check for number of waitiers in TrackingConnectionPool * [automatic failover] Configure max total connections for EchoStrategy (#4268) - set maxtotal connections for echoStrategy * [automatic failover] Replace 'CircuitBreaker' with 'Cluster' for 'CircuitBreakerFailoverBase.clusterFailover' (#4275) * - replace CircuitBreaker with Cluster for CircuitBreakerFailoverBase.clusterFailover - improve thread safety with provider initialization * - formatting * [automatic failover] Minor optimizations on fast failover (#4277) * - minor optimizations on fail fast * - volatile failfast * [automatic failover] Implement health check retries (#4273) * - replace minConsecutiveSuccessCount with numberOfRetries - add retries into healtCheckImpl - apply changes to strategy implementations config classes - fix unit tests * - fix typo * - fix failing tests * - add tests for retry logic * - formatting * - format * - revisit numRetries for healthCheck ,replace with numProbes and implement built in policies - new types probecontext, ProbePolicy, HealthProbeContext - add delayer executor pool to healthcheckımpl - adjustments on worker pool of healthCheckImpl for shared use of workers * - format * - expand comment with example case * - drop pooled executor for delays * - polish * - fix tests * - formatting * - checking failing tests * - fix test * - fix flaky tests * - fix flaky test * - add tests for builtin probing policies * - fix flaky test * [automatic failover] Move failover provider to mcf (#4294) * - move failover provider to mcf * - make iterateActiveCluster package private * [automatic failover] Add SSL configuration support to LagAwareStrategy (#4291) * User-provided ssl config for lag-aware health check * ssl scenario test for lag-aware healthcheck * format * format * address review comments - use getters instead of fields * [automatic failover] Implement max number of failover attempts (#4293) * - implement max failover attempt - add tests * - fix user receive the intended exception * -clean+format * - java doc for exceptions * format * - more tests on excaption types in max failover attempts mechanism * format * fix failing timing in test * disable health checks * rename to switchToHealthyCluster * format * - Add dual-threshold (min failures + failure rate) failover to circuit breaker executor - Map config to resilience4j via CircuitBreakerThresholdsAdapter - clean up/simplfy config: drop slow-call and window type - Add thresholdMinNumOfFailures; update some of the defaults - Update provider to use thresholds adapter - Update docs; align examples with new defaults - Add tests for 0% rate, edge thresholds * polish * Update src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsAdapter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * - fix typo * - fix min total calls calculation * format * - merge issues fixed * fix javadoc ref * - move threshold evaluations to failoverbase - simplfy executer and cbfailoverconnprovider - adjust config getters - fix failing tests due to COUNT_BASED -> TIME_BASED - new tests for thresholds calculations and impact on circuit state transitions * - avoid facilitating actual CBConfig type in tests * Update src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Trigger workflows * - evaluate only in failure recorded and failover immediately - add more test on threshold calculations - enable command line arg for overwriting surefire.excludedGroups * format * check pom * - fix error prone test * [automatic failover] Set and test default values for failover config&components (#4298) * - set & test default values * - format * - fix tests failing due to changing defaults * - fix flaky test * - remove unnecessary checks for failover attempt * - clean and trim adapter class - add docs and more explanantion * fix javadoc issue * - switch to all_succes to fix flaky timing * - fix issue in CircuitBreakerFailoverConnectionProvider * introduce ReflectionTestUtil --------- Co-authored-by: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [automatic failover] feat: Add MultiDbClient with multi-endpoint failover and circuit breaker support (#4300) * feat: introduce ResilientRedisClient with multi-endpoint failover support Add ResilientRedisClient extending UnifiedJedis with automatic failover capabilities across multiple weighted Redis endpoints. Includes circuit breaker pattern, health monitoring, and configurable retry logic for high-availability Redis deployments. * format * mark ResilientRedisClientTest as integration one * fix test - make sure endpoint is healthy before activating it * Rename ResilientClient to align with design - ResilientClient -> MultiDbClient (builder, tests, etc) * Rename setActiveEndpoint to setActiveDatabaseEndpoint * Rename clusterSwitchListener to databaseSwitchListener * Rename multiClusterConfig to multiDbConfig * fix api doc's error * fix compilation error after rebase * format * fix example in javadoc * Update ActiveActiveFailoverTest scenariou test to use builder's # Conflicts: # src/test/java/redis/clients/jedis/scenario/ActiveActiveFailoverTest.java * rename setActiveDatabaseEndpoint -. setActiveDatabase * is healthy throw exception if cluster does not exists * format * [automatic failover]Use Endpoint interface instead HostAndPort in multi db (#4302) [clean up] Use Endpoint interface where possible * - fix variable name type * fix typo in variable name * - fix flaky test --------- Co-authored-by: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ure rate) capabililty to circuit breaker (#4295) * [automatic failover] Remove the check for 'GenericObjectPool.getNumWaiters()' in 'TrackingConnectionPool' (#4270) - remove the check for number of waitiers in TrackingConnectionPool * [automatic failover] Configure max total connections for EchoStrategy (#4268) - set maxtotal connections for echoStrategy * [automatic failover] Replace 'CircuitBreaker' with 'Cluster' for 'CircuitBreakerFailoverBase.clusterFailover' (#4275) * - replace CircuitBreaker with Cluster for CircuitBreakerFailoverBase.clusterFailover - improve thread safety with provider initialization * - formatting * [automatic failover] Minor optimizations on fast failover (#4277) * - minor optimizations on fail fast * - volatile failfast * [automatic failover] Implement health check retries (#4273) * - replace minConsecutiveSuccessCount with numberOfRetries - add retries into healtCheckImpl - apply changes to strategy implementations config classes - fix unit tests * - fix typo * - fix failing tests * - add tests for retry logic * - formatting * - format * - revisit numRetries for healthCheck ,replace with numProbes and implement built in policies - new types probecontext, ProbePolicy, HealthProbeContext - add delayer executor pool to healthcheckımpl - adjustments on worker pool of healthCheckImpl for shared use of workers * - format * - expand comment with example case * - drop pooled executor for delays * - polish * - fix tests * - formatting * - checking failing tests * - fix test * - fix flaky tests * - fix flaky test * - add tests for builtin probing policies * - fix flaky test * [automatic failover] Move failover provider to mcf (#4294) * - move failover provider to mcf * - make iterateActiveCluster package private * [automatic failover] Add SSL configuration support to LagAwareStrategy (#4291) * User-provided ssl config for lag-aware health check * ssl scenario test for lag-aware healthcheck * format * format * address review comments - use getters instead of fields * [automatic failover] Implement max number of failover attempts (#4293) * - implement max failover attempt - add tests * - fix user receive the intended exception * -clean+format * - java doc for exceptions * format * - more tests on excaption types in max failover attempts mechanism * format * fix failing timing in test * disable health checks * rename to switchToHealthyCluster * format * - Add dual-threshold (min failures + failure rate) failover to circuit breaker executor - Map config to resilience4j via CircuitBreakerThresholdsAdapter - clean up/simplfy config: drop slow-call and window type - Add thresholdMinNumOfFailures; update some of the defaults - Update provider to use thresholds adapter - Update docs; align examples with new defaults - Add tests for 0% rate, edge thresholds * polish * Update src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsAdapter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * - fix typo * - fix min total calls calculation * format * - merge issues fixed * fix javadoc ref * - move threshold evaluations to failoverbase - simplfy executer and cbfailoverconnprovider - adjust config getters - fix failing tests due to COUNT_BASED -> TIME_BASED - new tests for thresholds calculations and impact on circuit state transitions * - avoid facilitating actual CBConfig type in tests * Update src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Trigger workflows * - evaluate only in failure recorded and failover immediately - add more test on threshold calculations - enable command line arg for overwriting surefire.excludedGroups * format * check pom * - fix error prone test * [automatic failover] Set and test default values for failover config&components (#4298) * - set & test default values * - format * - fix tests failing due to changing defaults * - fix flaky test * - remove unnecessary checks for failover attempt * - clean and trim adapter class - add docs and more explanantion * fix javadoc issue * - switch to all_succes to fix flaky timing * - fix issue in CircuitBreakerFailoverConnectionProvider * introduce ReflectionTestUtil --------- Co-authored-by: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

atakavci and others added 10 commits September 3, 2025 14:03

[automatic failover] Remove the check for 'GenericObjectPool.getNumW…

aaed216

…aiters()' in 'TrackingConnectionPool' (redis#4270) - remove the check for number of waitiers in TrackingConnectionPool

[automatic failover] Configure max total connections for EchoStrategy (…

beb5e14

…redis#4268) - set maxtotal connections for echoStrategy

[automatic failover] Replace 'CircuitBreaker' with 'Cluster' for 'Cir…

e972c21

…cuitBreakerFailoverBase.clusterFailover' (redis#4275) * - replace CircuitBreaker with Cluster for CircuitBreakerFailoverBase.clusterFailover - improve thread safety with provider initialization * - formatting

[automatic failover] Minor optimizations on fast failover (redis#4277)

55a96a9

* - minor optimizations on fail fast * - volatile failfast

[automatic failover] Move failover provider to mcf (redis#4294)

213e749

* - move failover provider to mcf * - make iterateActiveCluster package private

[automatic failover] Add SSL configuration support to LagAwareStrategy (

0d8e184

redis#4291) * User-provided ssl config for lag-aware health check * ssl scenario test for lag-aware healthcheck * format * format * address review comments - use getters instead of fields

polish

1f2d08d

atakavci requested review from a-TODO-rov, Copilot, ggivo and uglide September 26, 2025 17:21

atakavci self-assigned this Sep 26, 2025

atakavci added the feature label Sep 26, 2025

Copilot AI reviewed Sep 26, 2025

View reviewed changes

atakavci and others added 2 commits September 26, 2025 20:26

Update src/main/java/redis/clients/jedis/mcf/CircuitBreakerThresholds…

5fc7f88

…Adapter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- fix typo

96df57b

atakavci added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Sep 26, 2025

atakavci added 7 commits September 26, 2025 20:50

- fix min total calls calculation

d181287

Merge branch 'feature/automatic-failover-2' into ali/aa-failover-cbth…

f287158

…resholds

format

8fe5882

- merge issues fixed

f613319

fix javadoc ref

5a86dd8

- move threshold evaluations to failoverbase

01fe861

- simplfy executer and cbfailoverconnprovider - adjust config getters - fix failing tests due to COUNT_BASED -> TIME_BASED - new tests for thresholds calculations and impact on circuit state transitions

- avoid facilitating actual CBConfig type in tests

f3c01ed

atakavci requested a review from Copilot September 29, 2025 21:38

Copilot AI reviewed Sep 29, 2025

View reviewed changes

src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java Outdated Show resolved Hide resolved

Merge remote-tracking branch 'redis/feature/automatic-failover-3' int…

ac211fd

…o ali/aa-failover-cbthresholds

atakavci changed the base branch from feature/automatic-failover-2 to feature/automatic-failover-3 September 30, 2025 07:57

atakavci marked this pull request as draft September 30, 2025 11:10

atakavci marked this pull request as ready for review September 30, 2025 11:11

atakavci added 2 commits September 30, 2025 14:16

Trigger workflows

1daca8e

- evaluate only in failure recorded and failover immediately

801b167

- add more test on threshold calculations - enable command line arg for overwriting surefire.excludedGroups

atakavci requested a review from Copilot October 1, 2025 18:08

Copilot AI reviewed Oct 1, 2025

View reviewed changes

src/test/java/redis/clients/jedis/mcf/HealthCheckTest.java Show resolved Hide resolved

src/main/java/redis/clients/jedis/mcf/MultiClusterPooledConnectionProvider.java Show resolved Hide resolved

atakavci added 3 commits October 1, 2025 21:10

format

f774b00

check pom

1a8793a

- fix error prone test

b92b4bc

ggivo mentioned this pull request Oct 2, 2025

[automatic failover] feat: Add MultiDbClient with multi-endpoint failover and circuit breaker support #4300

Merged

atakavci added 3 commits October 2, 2025 13:32

[automatic failover] Set and test default values for failover config&…

8bbfd71

…components (redis#4298) * - set & test default values * - format * - fix tests failing due to changing defaults

Merge branch 'feature/automatic-failover-3' into ali/aa-failover-cbth…

7b25978

…resholds

- fix flaky test

2ea1b37

ggivo reviewed Oct 2, 2025

View reviewed changes

atakavci added 5 commits October 2, 2025 18:09

- remove unnecessary checks for failover attempt

e49f2e7

- clean and trim adapter class

f6cf533

- add docs and more explanantion

fix javadoc issue

4b9f00c

- switch to all_succes to fix flaky timing

3f736c1

- fix issue in CircuitBreakerFailoverConnectionProvider

086d973

ggivo reviewed Oct 3, 2025

View reviewed changes

introduce ReflectionTestUtil

fd35bb8

ggivo force-pushed the feature/automatic-failover-3 branch from 8bbfd71 to e22cd06 Compare October 3, 2025 09:04

Merge branch 'feature/automatic-failover-3' into ali/aa-failover-cbth…

eadab4d

…resholds

ggivo approved these changes Oct 3, 2025

View reviewed changes

atakavci merged commit 11308f0 into redis:feature/automatic-failover-3 Oct 3, 2025
11 checks passed

[automatic failover] Add dual thresholds (min num of failures + failure rate) capabililty to circuit breaker #4295

[automatic failover] Add dual thresholds (min num of failures + failure rate) capabililty to circuit breaker #4295

Uh oh!

Conversation

atakavci commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key changes

Behavior

Migration

Validation

Uh oh!

jit-ci bot commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

ggivo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggivo Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggivo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggivo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

atakavci commented Sep 26, 2025 •

edited

Loading

ggivo left a comment •

edited

Loading